-
Notifications
You must be signed in to change notification settings - Fork 185
Adding ability to set kube config from a dict. #195
Adding ability to set kube config from a dict. #195
Conversation
Welcome @vishnu667! |
/assign @yliaog |
please add tests for the change to kube_config_test.py |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 92.69% 92.54% -0.15%
==========================================
Files 13 13
Lines 1519 1557 +38
==========================================
+ Hits 1408 1441 +33
- Misses 111 116 +5
Continue to review full report at Codecov.
|
3ed1f12
to
e92495f
Compare
@yliaog I've added Some test cases, they are similar to the |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 92.69% 92.65% -0.04%
==========================================
Files 13 13
Lines 1519 1552 +33
==========================================
+ Hits 1408 1438 +30
- Misses 111 114 +3
Continue to review full report at Codecov.
|
/cc @yliaog |
242e78f
to
9181235
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishnu667, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a function called
load_kube_config_from_dict()
, adding the ability to set the~/.kube/config
file from a dict.Required where kubeconfig is stored externally and saving to disk is not an option.
Usage