Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

drop python2 support #238

Merged
merged 1 commit into from
May 17, 2021
Merged

drop python2 support #238

merged 1 commit into from
May 17, 2021

Conversation

Priyankasaggu11929
Copy link
Contributor

@Priyankasaggu11929 Priyankasaggu11929 commented May 14, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/kind clean-up

What this PR does / why we need it:

The PR makes changes to drop support for Python 2 from the next release (v18.0.0). The changes includes:

  • drop Python 2 from master branch
  • make sure all the tests use Python 3

Which issue(s) this PR fixes:

Fixes kubernetes-client/python#1413

Does this PR introduce a user-facing change?

The `python2` support will be removed in 18.0.0 beta release. All the tests will use `python3` versions.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v1700-snapshot

Signed-off-by: Priyanka Saggu [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 14, 2021
@k8s-ci-robot
Copy link
Contributor

@Priyankasaggu11929: The label(s) kind/clean-up cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind clean-up

What this PR does / why we need it:

The PR makes changes to drop support for Python 2 from the next release (v18.0.0). The changes includes:

  • drop Python 2 from master branch
  • make sure all the tests use Python 3
  • drop Python 2 from v18 beta release.

Which issue(s) this PR fixes:

Fixes kubernetes-client/python#1413

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v1700-snapshot

Signed-off-by: Priyanka Saggu [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 14, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from yliaog May 14, 2021 17:24
@k8s-ci-robot
Copy link
Contributor

Welcome @Priyankasaggu11929!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2021
@Priyankasaggu11929 Priyankasaggu11929 force-pushed the psaggu-drop-python2-support branch 2 times, most recently from 070ead3 to 1d6aabd Compare May 14, 2021 19:52
@Priyankasaggu11929
Copy link
Contributor Author

Just realised, it clones the https://github.com/kubernetes-client/python/ repo first, to run the pycodestyle test.

Will finish this PR, kubernetes-client/python#1468 first. Once that is merged, then will resume here.

Thank you!

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 17, 2021
@Priyankasaggu11929
Copy link
Contributor Author

Priyankasaggu11929 commented May 17, 2021 •
edited
Loading

@yliaog @roycaihw

[UPDATE]

I have done the following to remove Python 2 support:

  • removed python2 from the .travis.yaml file
  • removed python2 from the tox.ini file
  • tested coverage & codecov tests with python3 version (currently v3.9)
  • tested the updated update-pycodestyle.sh for python3 version v3.9. The script was updated by drop python 2 support python#1468

The CI jobs are green, with the above changes. Please review.
Thank you!

@Priyankasaggu11929 Priyankasaggu11929 changed the title [WIP] drop python2 support drop python2 support May 17, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021
@Priyankasaggu11929
drop python2 support
711d4ab 
 - remove python2 from the .travis.yaml file
 - remove python2 from the tox.ini file
 - remove `-y` flag from `isort` command in `update-pycodestle.sh` script
 - add update-pycodestyle, coverage & codecov tests for python3

Signed-off-by: Priyanka Saggu <[email protected]>
@yliaog
Copy link
Contributor

yliaog commented May 17, 2021

thanks for the pr
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 17, 2021
@Priyankasaggu11929
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit d25434b into kubernetes-client:master May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 2 support
3 participants
@Priyankasaggu11929 @k8s-ci-robot @yliaog