Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add '==' to base64 decode for py3 #67

Closed
wants to merge 1 commit into from
Closed

Add '==' to base64 decode for py3 #67

wants to merge 1 commit into from

Conversation

bcatubig
Copy link

@bcatubig bcatubig commented May 22, 2018

@codecov-io
Copy link

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          11       11           
  Lines         960      960           
=======================================
  Hits          897      897           
  Misses         63       63
Impacted Files Coverage Δ
config/kube_config.py 89.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5784a38...2e1bed1. Read the comment docs.

@hanikesn
Copy link

hanikesn commented Jun 5, 2018

The added padding should really depend on the lenght of the base64 string. See #70.

@bcatubig
Copy link
Author

bcatubig commented Jun 5, 2018

Thanks @hanikesn, will close this

@bcatubig bcatubig closed this Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants