Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC auth refresh flow differs from kubectl behavior #493

Closed
nurus opened this issue Mar 23, 2018 · 8 comments
Closed

OIDC auth refresh flow differs from kubectl behavior #493

nurus opened this issue Mar 23, 2018 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@nurus
Copy link

nurus commented Mar 23, 2018

I've been testing OIDC for authentication using the work done in kubernetes-client/python-base#48 and came across an issue refreshing credentials because I do not specify idp-certificate-authority-data in my kubeconfig. This issue has already been brought up: #368 (comment). As kubectl does not require this key I don't think the python client should either.

Another potential issue is the lack of support for the idp-certificate-authority key which allows you to load CA certificates from a file. I was attempting to use this to get around the issue mentioned above by loading a trusted root CA bundle. I could convert the entire file to base64 and add it as a value for idp-certificate-authority-data but this results in an unwieldy kubeconfig file.

mvle added a commit to mvle/python-base that referenced this issue May 23, 2018
@mvle
Copy link
Contributor

mvle commented May 23, 2018

I also ran into this problem when my kubeconfig does not have idp-certificate-authority-data field. This is not needed for kubectl and I don't think it should be forced on users w/o this requirement. It can be unsafe.
I created patch to skip over the certificate check when idp-certificate-authority-data is not specified.

Ping @yliaog

@yliaog
Copy link
Contributor

yliaog commented May 24, 2018

i think the patch looks good. idp-certificate-authority-data does not need to be required. could you send a PR?

mvle added a commit to mvle/python-base that referenced this issue May 25, 2018
mvle added a commit to mvle/python-base that referenced this issue May 25, 2018
mvle added a commit to mvle/python-base that referenced this issue May 25, 2018
@mvle
Copy link
Contributor

mvle commented Jun 6, 2018

ping @yliaog. PR is there, any chance for comment/review?

@yliaog
Copy link
Contributor

yliaog commented Jun 6, 2018

sorry for late response, i did not get notification about it until you pinged explicitly. the PR looks good.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dudleyhunt86 added a commit to dudleyhunt86/python-base-repository-build that referenced this issue Oct 7, 2022
bh717 pushed a commit to bh717/python-dapp that referenced this issue Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants