Fixes Setup.py error on Windows #676 #734

Sai-Adarsh · 2019-01-21T20:42:43Z

Fixes Setup.py error on Windows, added shell script to check python environment, prints the python version, copy files from /kubernetes/base to /kubernetes/ and finally runs python setup.py install issue #676

Fixes Setup,py error on Windows, added shell script to check python environment, print the python version, copy files from /kubernetes/base to /kubernetes/ and finally runs python setup.py install

k8s-ci-robot · 2019-01-21T20:42:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sai-Adarsh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sai-Adarsh · 2019-01-21T20:44:37Z

@micw523 gave a PR. could you check this out.

Sai-Adarsh · 2019-01-21T20:45:54Z

/assign @roycaihw

Sai-Adarsh · 2019-01-21T20:46:53Z

/assign @micw523

k8s-ci-robot · 2019-01-21T21:08:09Z

@Sai-Adarsh: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-01-21T21:09:08Z

@appendly: changing LGTM is restricted to assignees, and only kubernetes-client/python repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yliaog · 2019-01-22T17:57:24Z

scripts/setup-fix.bat

+	echo Python environment found..
+fi
+python --version
+cp -R ../kubernetes/base/* ../kubernetes/


what's the reason to do the 'cp -R' above?

what's the reason to do the 'cp -R' above?

"When we clone submodule with git the folders in the /kubernetes/base is supposed to be symbolically linked in the /kubernetes directory. In Windows this is not done. For a Windows developer, we’ll need to have a script copying all the base/* folders into */. "

^ is what @micw523 requested in his issue. so 'cp -R' does the job.

yliaog · 2019-01-22T17:59:06Z

scripts/setup-fix.bat

@@ -0,0 +1,11 @@
+if ! [ -x "$(command -v python)" ];
+then 
+	echo Python environment notfound..


probably add double quotes around the echo string

yliaog · 2019-01-22T17:59:14Z

scripts/setup-fix.bat

+then 
+	echo Python environment notfound..
+else 
+	echo Python environment found..


ditto

cool. will do the necessary changes

Suggested change

echo Python environment found..

echo Python environment found.

scripts/setup-fix.bat

micw523 · 2019-01-22T19:29:04Z

scripts/setup-fix.bat

+	echo "Python environment notfound.."
+else 
+	echo "Python environment found.."
+fi


Please check windows batch scripting syntax for if

micw523 · 2019-01-22T19:31:56Z

To be honest this looks like bash instead of a Windows bat. You could probably use it in a Cygwin but I think Windows developers would prefer a genuine bat.

Sai-Adarsh · 2019-01-24T18:31:09Z

@micw523 done with the changes. could you check on the new commit :)

micw523

I have a few comments -

Could you break your command into several lines? It is difficult to decipher at its current state
xcopy is considered an external program and has been deprecated since '07. Could you try using copy or robocopy?

Sai-Adarsh · 2019-01-24T18:56:24Z

I have a few comments -

Could you break your command into several lines? It is difficult to decipher at its current state

xcopy is considered an external program and has been deprecated since '07. Could you try using copy or robocopy?

done with the changes.

micw523 · 2019-01-24T19:10:17Z

scripts/setup-fix.bat

@@ -0,0 +1,5 @@
+( 	where python >null
+	echo Python environment found..


In this case Python environment found will be printed regardless.

python > null and found.

python > null and found.

cool. done with the changes.

micw523

Please fix your indents - the conditional statements are not aligned.
Also, one period for output message is sufficient.
On the last line ../ - the slash is not needed and on Windows you're supposed to use backslash anyway so cd .. should be good enough

Sai-Adarsh · 2019-01-24T21:38:07Z

Please fix your indents - the conditional statements are not aligned.
Also, one period for output message is sufficient.
On the last line ../ - the slash is not needed and on Windows you're supposed to use backslash anyway so cd .. should be good enough

done.

micw523

See suggestion

Sai-Adarsh · 2019-01-28T18:37:08Z

See suggestion

done with changes.

micw523 · 2019-01-28T19:28:20Z

/lgtm
/cc @roycaihw

roycaihw

/hold

Please add comments in the bat describing what it's for. Probably also name the file "windows-setup-fix.bat" to make it more clear. LGTM otherwise

roycaihw · 2019-01-29T01:43:38Z

scripts/setup-fix.bat

@@ -0,0 +1,6 @@
+(	python --version>nul 2>&1 && (
+	echo Python environment found.


just out of curiosity: was the double quote change @yliaog suggested reverted for some reason?

just out of curiosity: was the double quote change @yliaog suggested reverted for some reason?

works fine without double qoute, so thought of reverting the change :)

Sai-Adarsh · 2019-01-29T05:37:38Z

/hold

Please add comments in the bat describing what it's for. Probably also name the file "windows-setup-fix.bat" to make it more clear. LGTM otherwise

cool.

k8s-ci-robot · 2019-01-29T05:38:52Z

New changes are detected. LGTM label has been removed.

Sai-Adarsh · 2019-01-29T05:39:22Z

/hold

Please add comments in the bat describing what it's for. Probably also name the file "windows-setup-fix.bat" to make it more clear. LGTM otherwise

@roycaihw could you check on the new changes?

roycaihw · 2019-01-29T19:10:35Z

Could you add the comments to the beginning of the file? Basically I was asking for a description so that people can tell what it's for and when it should be used. I think we don't need inline comments.

Something like "Install python client in Windows. Windows doesn't have symbolic link that this repo uses. This batch script provides a workaround for symbolic link by copying the folders over."

Also please squash your commits before submit

/hold cancel

micw523 · 2019-02-07T20:25:13Z

Will lg()tm after squash

Sai-Adarsh · 2019-02-13T04:37:25Z

Will lg()tm after squash

cool.

Would like to join a GitHub team of kubernetes-client, and highly interested to join as a reviewer. Have previously merged a fix (kubernetes-client#734).

Fixes Setup,py error on Windows #676

4a3c232

Fixes Setup,py error on Windows, added shell script to check python environment, print the python version, copy files from /kubernetes/base to /kubernetes/ and finally runs python setup.py install

k8s-ci-robot requested review from mbohlool and yliaog January 21, 2019 20:42

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2019

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2019

k8s-ci-robot assigned roycaihw Jan 21, 2019

k8s-ci-robot assigned micw523 Jan 21, 2019

Sai-Adarsh changed the title ~~Fixes Setup,py error on Windows #676~~ Fixes Setup.py error on Windows #676 Jan 21, 2019

yliaog reviewed Jan 22, 2019

View reviewed changes

Update setup-fix.bat

769ef0e

micw523 suggested changes Jan 22, 2019

View reviewed changes

Update setup-fix.bat

51e0aab

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2019

Update setup-fix.bat

afb9158

micw523 reviewed Jan 24, 2019

View reviewed changes

Update setup-fix.bat

6a6d880

micw523 reviewed Jan 24, 2019

View reviewed changes

Update setup-fix.bat

357f23e

micw523 reviewed Jan 24, 2019

View reviewed changes

Update setup-fix.bat

37fcd69

Update setup-fix.bat

a7b035f

micw523 reviewed Jan 28, 2019

View reviewed changes

Update setup-fix.bat

e5bfc75

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019

k8s-ci-robot requested a review from roycaihw January 28, 2019 19:28

roycaihw reviewed Jan 29, 2019

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2019

Update and rename setup-fix.bat to windows-setup-fix.bat

f2dacbf

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2019

Sai-Adarsh added 3 commits January 29, 2019 11:10

Update windows-setup-fix.bat

13f3391

Update windows-setup-fix.bat

51ae885

Update windows-setup-fix.bat

3fb317f

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2019

Update windows-setup-fix.bat

b2e7232

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2019

Sai-Adarsh closed this Feb 20, 2019

Sai-Adarsh mentioned this pull request Feb 20, 2019

Fixes Setup.py error on Windows #676 #766

Merged

Sai-Adarsh mentioned this pull request Mar 8, 2019

Updated kubernetes-client owners with sai-adarsh kubernetes/org#583

Closed

Sai-Adarsh mentioned this pull request Mar 9, 2019

Updating kubernetes-client owners with sai-adarsh #776

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Setup.py error on Windows #676 #734

Fixes Setup.py error on Windows #676 #734

Sai-Adarsh commented Jan 21, 2019 •

edited

Loading

k8s-ci-robot commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

k8s-ci-robot commented Jan 21, 2019

k8s-ci-robot commented Jan 21, 2019

yliaog Jan 22, 2019

Sai-Adarsh Jan 22, 2019

yliaog Jan 22, 2019

yliaog Jan 22, 2019

Sai-Adarsh Jan 22, 2019

micw523 Jan 28, 2019

micw523 Jan 22, 2019

micw523 commented Jan 22, 2019

Sai-Adarsh commented Jan 24, 2019

micw523 left a comment

Sai-Adarsh commented Jan 24, 2019

micw523 Jan 24, 2019

micw523 Jan 24, 2019

Sai-Adarsh Jan 24, 2019

micw523 left a comment

Sai-Adarsh commented Jan 24, 2019

micw523 left a comment

Sai-Adarsh commented Jan 28, 2019

micw523 commented Jan 28, 2019

roycaihw left a comment

roycaihw Jan 29, 2019

Sai-Adarsh Jan 29, 2019

Sai-Adarsh commented Jan 29, 2019

k8s-ci-robot commented Jan 29, 2019

Sai-Adarsh commented Jan 29, 2019

roycaihw commented Jan 29, 2019

micw523 commented Feb 7, 2019

Sai-Adarsh commented Feb 13, 2019

	echo Python environment found..
	echo Python environment found.

		@@ -0,0 +1,5 @@
		( where python >null
		echo Python environment found..

		@@ -0,0 +1,6 @@
		( python --version>nul 2>&1 && (
		echo Python environment found.

Fixes Setup.py error on Windows #676 #734

Fixes Setup.py error on Windows #676 #734

Conversation

Sai-Adarsh commented Jan 21, 2019 • edited Loading

k8s-ci-robot commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

Sai-Adarsh commented Jan 21, 2019

k8s-ci-robot commented Jan 21, 2019

k8s-ci-robot commented Jan 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micw523 commented Jan 22, 2019

Sai-Adarsh commented Jan 24, 2019

micw523 left a comment

Choose a reason for hiding this comment

Sai-Adarsh commented Jan 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micw523 left a comment

Choose a reason for hiding this comment

Sai-Adarsh commented Jan 24, 2019

micw523 left a comment

Choose a reason for hiding this comment

Sai-Adarsh commented Jan 28, 2019

micw523 commented Jan 28, 2019

roycaihw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sai-Adarsh commented Jan 29, 2019

k8s-ci-robot commented Jan 29, 2019

Sai-Adarsh commented Jan 29, 2019

roycaihw commented Jan 29, 2019

micw523 commented Feb 7, 2019

Sai-Adarsh commented Feb 13, 2019

Sai-Adarsh commented Jan 21, 2019 •

edited

Loading