Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hostpath Don't give expected output #207

Closed
Kartik494 opened this issue Oct 8, 2020 · 7 comments
Closed

make hostpath Don't give expected output #207

Kartik494 opened this issue Oct 8, 2020 · 7 comments
Assignees

Comments

@Kartik494
Copy link
Member

When i run command "make hostpath" from my root directory i got the error as "make: *** No rule to make target 'hostpath'. Stop."
and in make file the argument is used for build is: all
CMDS=hostpathplugin
all: build

include release-tools/build.make

However when i changes the argument all to hostpath then the command "make hostpath" is executed

CMDS=hostpathplugin
hostpath: build

include release-tools/build.make

So in Docs should we update make hostpath command to make all ?

@Kartik494
Copy link
Member Author

/assign

@pohly
Copy link
Contributor

pohly commented Oct 9, 2020

Works for me. I'm using:

  • GNU Make 4.2.1
  • Debian GNU/Linux 10 (buster)
  • csi-driver-host-path master (= 123fa4e).

all depends on build, which depends on $(CMDS:%=build-%).

I've not checked whether the latter is part of POSIX make or specific to GNU Make.

@Kartik494
Copy link
Member Author

Hi @pohly Thanks for input , could you please suggest is there any pre-requisite i have to follow for running the command make hostpath in my envoirment. Is the GNU Make is specific to be at 4.2.1 version? Because i am still facing issue in that , only command is working for me is when i change this to make all or make. Please Suggest

@pohly
Copy link
Contributor

pohly commented Oct 15, 2020

Now I get it. It's failing for your because you literally are running make hostpath.

That simply isn't a valid invocation because there is no such build target, as make is pointing out.

If you want to build the binary, use make without a build target. That works in any of the Kubernetes-CSI repos, so you don't have to figure out what the binary is called.

@Kartik494
Copy link
Member Author

If you want to build the binary, use make without a build target. That works in any of the Kubernetes-CSI repos, so you don't have to figure out what the binary is called.

@pohly Yes when i use without build target then it works fine for me i.e by simply running make command , i will be closing this issue.
Thanks

@Kartik494
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@Kartik494: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane added a commit to jsafrane/csi-driver-host-path that referenced this issue Nov 10, 2022
78c0fb71 Merge pull request kubernetes-csi#208 from jsafrane/skip-selinux
36e433e2 Skip SELinux tests in CI by default
348d4a92 Merge pull request kubernetes-csi#207 from RaunakShah/reviewers
1efc2724 Merge pull request kubernetes-csi#206 from RaunakShah/update-prow
7d410d88 Changes to csi prow to run e2e tests in sidecars
cfa5a75c Merge pull request kubernetes-csi#203 from humblec/test-vendor
4edd1d8a Add RaunakShah to CSI reviewers group
7ccc9594 release tools update to 1.19

git-subtree-dir: release-tools
git-subtree-split: 78c0fb714fa4448b29962a0f34fa18b7b7d97ae6
jsafrane added a commit to jsafrane/csi-driver-host-path that referenced this issue Nov 10, 2022
78c0fb71 Merge pull request kubernetes-csi#208 from jsafrane/skip-selinux
36e433e2 Skip SELinux tests in CI by default
348d4a92 Merge pull request kubernetes-csi#207 from RaunakShah/reviewers
1efc2724 Merge pull request kubernetes-csi#206 from RaunakShah/update-prow
7d410d88 Changes to csi prow to run e2e tests in sidecars
cfa5a75c Merge pull request kubernetes-csi#203 from humblec/test-vendor
4edd1d8a Add RaunakShah to CSI reviewers group
7ccc9594 release tools update to 1.19

git-subtree-dir: release-tools
git-subtree-split: 78c0fb714fa4448b29962a0f34fa18b7b7d97ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants