Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Go version 1.13 #111

Closed
wants to merge 5 commits into from
Closed

WIP: Go version 1.13 #111

wants to merge 5 commits into from

Commits on Oct 31, 2019

  1. Add new variables for 1.16 and remove 1.13

    @msau42
    msau42 committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    e0fde8c View commit details
    Browse the repository at this point in the history

  2. Merge pull request kubernetes-csi#40 from msau42/add-1.16 

    Add new variables for 1.16 and remove 1.13
    @k8s-ci-robot
    k8s-ci-robot authored Oct 31, 2019
    Configuration menu
    Copy the full SHA
    f419d74 View commit details
    Browse the repository at this point in the history

  3. update CI to use Go 1.13.3 

    This is the latest release. Updating is useful to ensure that we have
all of the latest fixes and enhancements.
    @pohly
    pohly committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    5e773d2 View commit details
    Browse the repository at this point in the history

  4. better handling of Go version 

    Some operations are sensitive to the version of Go that is used. In
the past, formatting of source differed depending on the
version. Right now it is the content of the vendor directory which
changes when switch back and forth between 1.12 and 1.13.

We don't want to impose a certain workflow on developers, like forcing
all invocations of Go to run inside a container. If developers want
that, they can set up their development environment accordingly.

But we should warn about this aspect to raise awareness. "make"
invocations which involve Go now compare against the projects Go
version (specified in travis.yml) once at the beginning. This is only
a warning because we don't know which future version will be
compatible with the project.

Vendor directory handling gets updated, too: verification is now a
separate script (became too complex for make) and there is a
corresponding "update-vendor.sh". In contrast to verification,
updating vendor is not integrated into make and thus itself invokes
the go version check.
    @pohly
    pohly committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    c8a1c4a View commit details
    Browse the repository at this point in the history

  5. release-tools: update to Go 1.13 

    This imports the version bump of Go to 1.13.3.

The "vendor" directory needs to be refreshed because Go 1.13 handles
it a bit differently.
    @pohly
    pohly committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    c42177f View commit details
    Browse the repository at this point in the history