Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos #2

Closed
wants to merge 1 commit into from
Closed

Fix minor typos #2

wants to merge 1 commit into from

Conversation

rollandf
Copy link

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rollandf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: saad-ali

If they are not already assigned, you can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 24, 2019
@rollandf
Copy link
Author

Signed CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 24, 2019
pohly pushed a commit to pohly/csi-driver-host-path that referenced this pull request Jan 24, 2019
README.md: fix repo URL for initial setup
@rollandf
Copy link
Author

rollandf commented Feb 6, 2019

/assign @saad-ali

@okartau
Copy link
Contributor

okartau commented Feb 20, 2019

can we also (to save creation of separate PR) add in this PR fix of remaining two typos that I was able to spot:
under ## Deployment:

-The easiest way to test the Hostpath driver is to run `deploy/deploy-hostpath.sh` scrip as show:
+The easiest way to test the Hostpath driver is to run `deploy/deploy-hostpath.sh` script as shown:

@rollandf
Copy link
Author

can we also (to save creation of separate PR) add in this PR fix of remaining two typos that I was able to spot:
under ## Deployment:

-The easiest way to test the Hostpath driver is to run `deploy/deploy-hostpath.sh` scrip as show:
+The easiest way to test the Hostpath driver is to run `deploy/deploy-hostpath.sh` script as shown:

Done

@okartau
Copy link
Contributor

okartau commented Mar 1, 2019

once I started piggy-backing my ideas onto another PR...
Some shell prompts in command examples are $ and some are $>, seems a copy-paste leftover artifact.
I propose to unify all to be $,
'>', with it's meaning in shell, is not friendly character in examples.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2019
@rollandf
Copy link
Author

rollandf commented Mar 5, 2019

once I started piggy-backing my ideas onto another PR...
Some shell prompts in command examples are $ and some are $>, seems a copy-paste leftover artifact.
I propose to unify all to be $,
'>', with it's meaning in shell, is not friendly character in examples.

Done

@okartau
Copy link
Contributor

okartau commented Mar 29, 2019

Based on proposal by @pohly, I included all fixes from here in #31, which is about big changes in README and would require rebase of this PR here anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants