Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples fix #65

Merged
merged 1 commit into from
Jul 10, 2019
Merged

examples fix #65

merged 1 commit into from
Jul 10, 2019

Commits on Jul 8, 2019

  1. README.md: fix and clarify examples

    The previous `kubectl create -f examples` no longer worked as intended
    after adding several more example yamls, in particular because
    csi-app-inline.yaml reused the pod name.
    
    When selecting files explicitly, the previous example works again as
    before. The pod name in csi-app-inline.yaml gets changed such that it
    can be used in parallel.
    
    This approach was chosen instead of moving files into sub-directories
    because csi-storageclass.yaml is needed by more than one example. When
    using "kubectl apply" instead of "kubectl create" we
    could (theoretically) re-use files in different examples without
    causing errors. In practice, the raw block example is currently not
    explicitly called out in the README.md.
    
    The snapshotting example however can't be used stand-alone and depends
    on the simple PVC.
    pohly committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    cd0f09f View commit details
    Browse the repository at this point in the history