fix: Remove stale archived volume copy before Rename

[mpatlasov]

The user might put non-unique spec for subdir:

subDir: ${pvc.metadata.namespace}/${pvc.metadata.name}

Then, os.Rename(internalVolumePath, archivedInternalVolumePath) can fail becaue the destination (archivedInternalVolumePath) already exists. It's safer to remove it before os.Rename().

What type of PR is this?

/kind bug

What this PR does / why we need it:

Sensitive user data may leak across Pod create/delete in spite of reclaim policy "Delete". See https://github.com/kubernetes-csi/csi-driver-smb/security/advisories/GHSA-rmg6-rh96-c9wx for details.

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-csi/csi-driver-smb/security/advisories/GHSA-rmg6-rh96-c9wx

Special notes for your reviewer:

Release note:

Previously, in archiveOnDelete mode, it was possible that PV cannot not archived because previously archived volume keeps the same name. Now, such a stale archived item is deleted before archiving new one.

[k8s-ci-robot]

Welcome @mpatlasov!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mpatlasov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mpatlasov]

/assign @andyzhangx

[andyzhangx]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 9025414512

Details

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 79.093%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/controllerserver.go	0	3	0.0%

Totals
Change from base Build 9012697057:	-0.2%
Covered Lines:	942
Relevant Lines:	1191

---

💛 - Coveralls

[andyzhangx]

/retest

[k8s-ci-robot]

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-csi-driver-smb-sanity	2ccfaa0	link	true	/test pull-csi-driver-smb-sanity

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andyzhangx]

/test pull-csi-driver-smb-e2e-capz

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment