Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ProbeForever behavior of probing first before sleeping #175

Merged
merged 2 commits into from
May 30, 2024
Merged

Restore ProbeForever behavior of probing first before sleeping #175

merged 2 commits into from
May 30, 2024

Commits on May 30, 2024

  1. [rpc] defer Stop ticker for GC

    @Fricounet
    Fricounet committed May 30, 2024
    Configuration menu
    Copy the full SHA
    856c5da View commit details
    Browse the repository at this point in the history

  2. [rpc] Run the probe first 

    The previous beheavior of ProbeForever was to try a probe and then sleep for the `probeInterval` duration. When it was modified to use a `time.Ticker` instead of a sleep, it changed the behavior to wait the `probeInterval` first and then do the probe. This commit restore the previous behavior by running the probe first. Based on https://stackoverflow.com/a/54752803.
    @Fricounet
    Fricounet committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a8003ad View commit details
    Browse the repository at this point in the history