Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mount and staging dir creation flexible #159

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Make mount and staging dir creation flexible #159

merged 4 commits into from
Mar 20, 2019

Commits on Mar 20, 2019

  1. Make mount and staging dir creation flexible 

    This change adds an option to attach callback functions to CSI sanity
for mount target directory creation. This could be used to customize the
target and staging mount path creation.

Also, adds `targetPath` and `stagingPath` fields to `SanityContext` to
store the actual target and staging paths, derived from the sanity
config.

Adds an e2e test section to test the above setup.
    @darkowlzz
    darkowlzz committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    4000ec5 View commit details
    Browse the repository at this point in the history

  2. Add target path checks and rm paths at teardown 

    This adds target path exists checks in the mock driver in
NodeStageVolume and NodePublishVolume to ensure that the paths actually
exist.

Also adds path cleanup in the teardown. This ensures that every test
creates and deletes their target directories. Without this, the test
setup function for Controller only tests created the target directory
and the same was being used by subsequent tests.
    @darkowlzz
    darkowlzz committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    cbc42e8 View commit details
    Browse the repository at this point in the history

  3. Add command line support for custom target paths 

    This adds three new flags to support custom target path creation:

- `createmountpathcmd`: Command to create a custom mount path.
- `createstagingpathcmd`: Command to create a custom staging path.
- `createpathcmdtimeout`: Timeout for the custom path creation commands.

Also adds a new test section in e2e tests to test this custom command
support.
    @darkowlzz
    darkowlzz committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    a9b0016 View commit details
    Browse the repository at this point in the history

  4. Add support for custom target path removal 

    This adds three new flags to support custom target path removal:

- `removemountpathcmd`: Command to remove a custom mount path.
- `removestagingpathcmd`: Command to remove a custom staging path.
- `removepathcmdtimeout`: Timeout for the custom path removal commands.
    @darkowlzz
    darkowlzz committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    506d128 View commit details
    Browse the repository at this point in the history