strict staging and target directory #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
The CSI spec requires the CO (= csi-sanity) to create the staging directory and the *parent* of the target directory. Kubernetes (kubernetes/kubernetes#75535) and csi-sanity have handled the target directory incorrectly by creating it. Now directory handling is standard-compliant and more strict, to catch mistakes: - the specified target directory is treated as the parent which gets created by csi-sanity, while the actual NodePublishVolume call then specifies an entry inside that directory; this was done to keep the code simple (handling both directories is the same) and to minimize API changes - os.Mkdir and os.Remove are used instead of the more forgiving os.MkdirAll and os.RemoveAll; as a result, both directories now must be different (which is what they should have been in the anyway, it just happened to work when they were identical) - the mock driver checks for non-existence of the target directory
|
/lgtm |
k8s-ci-robot
added
the
lgtm
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
strict staging and target directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSI spec requires the CO (= csi-sanity) to create the staging
directory and the parent of the target
directory. Kubernetes (kubernetes/kubernetes#75535)
and csi-sanit have handled the target directory incorrectly by
creating it.
Now directory handling is standard-compliant and more strict, to catch
mistakes:
created by csi-sanity, while the actual NodePublishVolume call then
specifies an entry inside that directory; this was done to keep the
code simple (handling both directories is the same) and to minimize
API changes
os.MkdirAll and os.RemoveAll; as a result, both directories
now must be different (which is what they should have been in the
anyway, it just happened to work when they were identical)