Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise SINGLE_NODE_MULTI_WRITER capability #342

Merged

Conversation

chrishenzie
Copy link
Contributor

@chrishenzie chrishenzie commented May 16, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR allows the mock driver to advertise the SINGLE_NODE_MULTI_WRITER capability and accept the SINGLE_NODE_SINGLE_WRITER and SINGLE_NODE_MULTI_WRITER access modes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

avoid test failures when a CSI driver advertises the  SINGLE_NODE_MULTI_WRITER capability from CSI 1.5

/assign @msau42
/assign @jingxu97

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 16, 2021
@chrishenzie chrishenzie changed the title WIP: Advertise SINGLE_NODE_MULTI_WRITER capability Advertise SINGLE_NODE_MULTI_WRITER capability Jun 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2021
@chrishenzie
Copy link
Contributor Author

This PR is ready for review now that the CSI spec has been released.

@xing-yang
Copy link
Contributor

Can you remove the special notes as you don't need that now? I don't think this needs a release note. Can you remove it?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 14, 2021
@chrishenzie
Copy link
Contributor Author

@xing-yang Done

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3de1c6c into kubernetes-csi:master Jun 14, 2021
@chrishenzie chrishenzie deleted the single-node-access-modes branch June 14, 2021 21:26
@msau42
Copy link
Collaborator

msau42 commented Jul 7, 2021

I believe we're moving away from mock driver and using hostpath driver instead.

@pohly
Copy link
Contributor

pohly commented Jul 8, 2021

The deprecation was announced in https://github.com/kubernetes-csi/csi-test/releases/tag/v4.2.0

We don't have a regular release schedule for csi-test. Shall I remove the source code from master now and then do a 5.0.0 immediately or wait, say, half a year (= October)?

I'm undecided about the version. The remaining code is mostly unchanged compared to 4.2.0.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants