-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise SINGLE_NODE_MULTI_WRITER capability #342
Advertise SINGLE_NODE_MULTI_WRITER capability #342
Conversation
8ff2ed5
to
2168f5e
Compare
This PR is ready for review now that the CSI spec has been released. |
Can you remove the special notes as you don't need that now? I don't think this needs a release note. Can you remove it? |
@xing-yang Done |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I believe we're moving away from mock driver and using hostpath driver instead. |
The deprecation was announced in https://github.com/kubernetes-csi/csi-test/releases/tag/v4.2.0 We don't have a regular release schedule for csi-test. Shall I remove the source code from master now and then do a 5.0.0 immediately or wait, say, half a year (= October)? I'm undecided about the version. The remaining code is mostly unchanged compared to 4.2.0. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows the mock driver to advertise the
SINGLE_NODE_MULTI_WRITER
capability and accept theSINGLE_NODE_SINGLE_WRITER
andSINGLE_NODE_MULTI_WRITER
access modes.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/assign @msau42
/assign @jingxu97