Add --timeout parameter #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jsafrane
force-pushed
the
add-csi-timeout
branch
from
8a7d5cc
to
33cc39c
Compare
|
Edit: renamed to |
davidz627
reviewed
Feb 11, 2019
| @@ -59,6 +59,7 @@ var ( | |||
| retryIntervalStart = flag.Duration("retry-interval-start", time.Second, "Initial retry interval of failed provisioning or deletion. It doubles with each failure, up to retry-interval-max.") | |||
| retryIntervalMax = flag.Duration("retry-interval-max", 5*time.Minute, "Maximum retry interval of failed provisioning or deletion.") | |||
| workerThreads = flag.Uint("worker-threads", 100, "Number of provisioner worker threads, in other words nr. of simultaneous CSI calls.") | |||
| csiTimeout = flag.Duration("timeout", 10*time.Second, "Timeout for waiting for creation or deletion of a volume") | |||
There was a problem hiding this comment.
nit: operationTimeout, provisioningTimeout, createDeleteTimeout, rpcTimeout?
Everything in this package is "csi." To me it does not seem descriptive enough for what it actually is.
The name of the flag itself too timeout is not very specific, considering we also have connection-timeout
There was a problem hiding this comment.
--timeout is already established in external-attacher and prefer consistency. For variable name, operationTimeout sounds good.
jsafrane
force-pushed
the
add-csi-timeout
branch
from
33cc39c
to
4731200
Compare
|
looks like gofmt is not happy |
k8s-ci-robot
added
the
lgtm
jsafrane
force-pushed
the
add-csi-timeout
branch
from
4731200
to
45a92e2
Compare
k8s-ci-robot
removed
the
lgtm
|
Fixed gofmt, PTAL. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Pinging bot |
humblec
added a commit
to humblec/external-provisioner
that referenced
this pull request
Aug 3, 2023
63473cc96 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76c7 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd28211b Update cloudbuild image with go 1.20.5 1df23dba6 Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7c Add ginkgo timeout to e2e tests to help catch any stuck tests c10b67804 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec0a chore: adopt kubernetes recommand label b05553510 Header bd0a10b65 typo c39d73c33 Add comments f6491af0e Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 63473cc96f0c3cbde73a9a1e5844c24f8c7d5dae
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Remove update from rbac. It has been replaced by patch
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227