Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore non-migrated in-tree PVC when provisioning #344

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Ignore non-migrated in-tree PVC when provisioning #344

merged 2 commits into from
Oct 1, 2019

Conversation

davidz627
Copy link
Contributor

Cherry-pick of: #341

/kind bug
/assign @jsafrane @msau42
/cc @ddebroy @leakingtapan

Fixes issue where provisioner provisions volumes for in-tree PVC's which have not been migrated

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2019
@jsafrane
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2019
@jsafrane
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@msau42
Copy link
Collaborator

msau42 commented Sep 20, 2019

/retest

@msau42
Copy link
Collaborator

msau42 commented Sep 20, 2019

I disabled travis PR testing, but we may have to manually merge this one

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2019
@davidz627
Copy link
Contributor Author

@msau42 @jsafrane fixed travis with dummy commit

@msau42
Copy link
Collaborator

msau42 commented Oct 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@davidz627
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14

@k8s-ci-robot k8s-ci-robot merged commit 9bccfb1 into kubernetes-csi:release-1.3 Oct 1, 2019
@davidz627 davidz627 deleted the 13 branch October 1, 2019 23:07
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
@k8s-ci-robot
Merge pull request kubernetes-csi#344 from chrishenzie/prow-update-ma…
c51ab62 
…ster

master: update release-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidz627 @jsafrane @k8s-ci-robot @msau42