Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for external resize controller #5

Closed
gnufied opened this issue Jan 7, 2019 · 2 comments · Fixed by #40
Closed

Add unit test for external resize controller #5

gnufied opened this issue Jan 7, 2019 · 2 comments · Fixed by #40
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gnufied
Copy link
Contributor

gnufied commented Jan 7, 2019

We need some basic unit tests and sanity checks for controller.
@andrewsykim andrewsykim mentioned this issue Feb 27, 2019
Merged
pohly pushed a commit to pohly/external-resizer that referenced this issue Mar 4, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#5 from pohly/test-enhancements
33d58fd 
test enhancements
@gnufied
Copy link
Contributor Author

gnufied commented Mar 5, 2019

@jarrpa is looking into this.

pohly pushed a commit to pohly/external-resizer that referenced this issue Mar 6, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#5 from pohly/test-enhancements
9c43610 
test enhancements
@jarrpa jarrpa mentioned this issue Apr 26, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2019
jsafrane pushed a commit to jsafrane/external-resizer that referenced this issue Oct 16, 2019
@openshift-merge-robot
Merge pull request kubernetes-csi#5 from huffmanca/rebase-0.3.0
2413e7d 
Rebase 0.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add controller tests jarrpa/external-resizer
3 participants
@gnufied @k8s-ci-robot @fejta-bot