Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Suggestion: Validate if existing subnets have appropriate tags added #779

Closed
mumoshu opened this issue Jul 19, 2017 · 6 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Jul 19, 2017

As required by K8S, and emit validation errors accordingly so that users can notice what action(s) are required in order to deploy a kube-aws cluster into existing subnet(s).

Ref #52 (comment)

cc @redbaron @c-knowles @danielfm @camilb

@mumoshu mumoshu changed the title Validate if existing subnets have appropriate tags added Suggestion: Validate if existing subnets have appropriate tags added Jul 19, 2017
@redbaron
Copy link
Contributor

It can't be an error as tags are not mandatory for cluster to function. lets say if service type LoadBalancer is never used, then no tags is needed. It can be a warning at best.

@mumoshu
Copy link
Contributor Author

mumoshu commented Jul 19, 2017

@redbaron Good point 👍
I was under the impression that we'd want to enable type: LoadBalancer services even for a cluster deployed into existing subnet(s) but yes, the service type isn't addressed even in the K8S conformance test hence it can not be said as a "requirement" of a K8S cluster.
A warning would be nice.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants