This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Remove service should remove the deployments #1952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this package with any newer Kubernetes version. But it always fails to cleanup the services cause it tries to remove the replica controllers. It should remove the deployments instead when using the current version.
I wanted to add some other improvements but I want to start with something smaller :).
ping @mikedanese
This change is