Convert registry to k8s.gcr.io #2814

thockin · 2017-12-22T18:00:25Z

This PR was auto-generated. Please apply human expertise to review for correctness.

Followup to kubernetes/kubernetes#54174 and kubernetes/kubernetes#57824

xref kubernetes/release#281

k8s-reviewable · 2017-12-22T18:00:32Z

This change is

bowei · 2017-12-22T18:19:10Z

lgtm

MrHohn

/lgtm

porridge

Sorry, but this does not work.
I can push to the old location but not the new one:

porridge@kielonek:~/projects/go/src/k8s.io/contrib/perfdash$ gcloud docker -- tag gcr.io/google_containers/perfdash:0.8 k8s.gcr.io/perfdash:0.8
porridge@kielonek:~/projects/go/src/k8s.io/contrib/perfdash$ gcloud docker -- push  k8s.gcr.io/perfdash:0.8
The push refers to a repository [k8s.gcr.io/perfdash]
45f4f6715eed: Pushing [==================================================>] 137.2 kB
eacb8c6cad16: Pushing [==========================>                        ] 2.819 MB/5.321 MB
df6868d54704: Pushing [=====================>                             ] 2.805 MB/6.572 MB
8880784f79cf: Pushing [====>                                              ] 3.518 MB/36.78 MB
46ecc6c4543a: Pushing [>                                                  ] 2.126 MB/163.5 MB
5f70bf18a086: Waiting 
unexpected EOF
# (The above retries several times before failing)
porridge@kielonek:~/projects/go/src/k8s.io/contrib/perfdash$ gcloud docker -- tag gcr.io/google_containers/perfdash:0.8 gcr.io/google_containers/perfdash:0.8-test
porridge@kielonek:~/projects/go/src/k8s.io/contrib/perfdash$ gcloud docker -- push  gcr.io/google_containers/perfdash:0.8-test
The push refers to a repository [gcr.io/google_containers/perfdash]
45f4f6715eed: Layer already exists 
eacb8c6cad16: Layer already exists 
df6868d54704: Layer already exists 
8880784f79cf: Layer already exists 
46ecc6c4543a: Layer already exists 
5f70bf18a086: Layer already exists 
0.8-test: digest: sha256:b1ed038f1e032ea33fb48672d779f96a4c225140381ec8ba7ee29648dae2981f size: 1783

thockin · 2017-12-28T17:14:36Z

@dekkagaijin I, too, am experiencing issues. This all worked at some point.

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'

thockin@freakshow2 kubernetes gcr-vanity /$ docker pull gcr.io/google_containers/pause
Using default tag: latest
latest: Pulling from google_containers/pause
a3ed95caeb02: Pull complete 
4964c72cd024: Pull complete 
Digest: sha256:a78c2d6208eff9b672de43f880093100050983047b7b0afe0217d3656e1b0d5f
Status: Downloaded newer image for gcr.io/google_containers/pause:latest

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'
gcr.io/google_containers/pause                   latest                        350b164e7ae1        3 years ago         239.8 kB

thockin@freakshow2 kubernetes gcr-vanity /$ docker tag gcr.io/google_containers/pause k8s.gcr.io/thtest:thtest 

thockin@freakshow2 kubernetes gcr-vanity /$ docker images | egrep '(pause|thtest)'
gcr.io/google_containers/pause                   latest                        350b164e7ae1        3 years ago         239.8 kB
k8s.gcr.io/thtest                                thtest                        350b164e7ae1        3 years ago         239.8 kB

thockin@freakshow2 kubernetes gcr-vanity /$ gcloud docker -- push k8s.gcr.io/thtest:thtest
The push refers to a repository [k8s.gcr.io/thtest]
5f70bf18a086: Layer already exists 
e16a89738269: Pushing [==================================================>] 241.7 kB
unexpected EOF

dekkagaijin · 2017-12-28T19:18:53Z

2 possible solutions:

update gcloud to >= 183.0.0 (where k8s.gcr.io was added as a default domain)
use gcloud docker -s k8s.gcr.io -- push ...

thockin · 2017-12-28T19:20:41Z

Confirmed, update worked for me

…

On Thu, Dec 28, 2017 at 11:18 AM, Jake Sanders ***@***.***> wrote: 2 possible solutions: updated gcloud to >= 183.0.0 (where k8s.gcr.io was added as a default domain) or use gcloud docker -s k8s.gcr.io -- push ... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2814 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVHCaf2uNGvliyE1B62fMImRIUGMUks5tE-migaJpZM4RLSS9> .

porridge

The -s flag worked as well.
/lgtm

mikedanese · 2018-01-02T19:42:35Z

/approve

k8s-github-robot · 2018-01-13T08:00:44Z

@thockin PR needs rebase

mikedanese · 2018-01-13T20:32:21Z

/approve

dekkagaijin · 2018-01-17T19:44:45Z

election/Makefile

@@ -3,10 +3,10 @@ all: push
 # 0.0 shouldn't clobber any released builds
 # current latest is 0.5
 TAG = 0.0
-PREFIX = gcr.io/google_containers/leader-elector
+PREFIX = k8s.gcr.io/leader-elector


PREFIX = staging-k8s.gcr.io/leader-elector

dekkagaijin · 2018-01-17T19:45:00Z

election/Makefile


 NODEJS_TAG = 0.1
-NODEJS_PREFIX = gcr.io/google_containers/nodejs-election-client
+NODEJS_PREFIX = k8s.gcr.io/nodejs-election-client


NODEJS_PREFIX = staging-k8s.gcr.io/nodejs-election-client

dekkagaijin · 2018-01-17T19:46:49Z

election/Makefile


 NODEJS_TAG = 0.1
-NODEJS_PREFIX = gcr.io/google_containers/nodejs-election-client
+NODEJS_PREFIX = k8s.gcr.io/nodejs-election-client

 server:
 	CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -ldflags '-w' -o server example/main.go


push below will need to be modified to:
gcloud docker -s staging-k8s.gcr.io -- push ...

Might be good to have a REGISTRY var

dekkagaijin · 2018-01-17T19:48:40Z

exec-healthz/Makefile

@@ -19,7 +19,7 @@ BIN := exechealthz
 PKG := k8s.io/contrib/exec-healthz

 # Where to push the docker image.
-REGISTRY ?= gcr.io/google_containers
+REGISTRY ?= k8s.gcr.io


REGISTRY ?= staging-k8s.gcr.io

and...

push:
...
@gcloud docker -s $(REGISTRY) -- push $(IMAGE):$(VERSION)

dekkagaijin · 2018-01-17T19:53:44Z

exec-healthz/README.md

@@ -12,19 +12,19 @@ How to build and push all images:
 # Build for linux/amd64 (default)
 $ make push TAG=1.0
 $ make push TAG=1.0 ARCH=amd64
-# ---> gcr.io/google_containers/exechealthz-amd64:1.0
+# ---> k8s.gcr.io/exechealthz-amd64:1.0


staging-k8s.gcr.io all the way down

dekkagaijin · 2018-01-17T20:06:29Z

node-perf-dash/Makefile

@@ -3,7 +3,7 @@ all: push
 # See pod.yaml for the version currently running-- bump this ahead before rebuilding!
 TAG = v0.3

-REPO = gcr.io/google_containers
+REPO = k8s.gcr.io


REGISTRY = staging-k8s.gcr.io REPO = $(REGISTRY) ... push: container gcloud docker -s $(REGISTRY) -- push $(REPO)/node-perf-dash:$(TAG)

dekkagaijin · 2018-01-17T20:07:26Z

peer-finder/Makefile

@@ -15,7 +15,7 @@
 all: push

 TAG = 0.1
-PREFIX = gcr.io/google_containers/peer-finder
+PREFIX = k8s.gcr.io/peer-finder


REGISTRY = staging-k8s.gcr.io PREFIX = $(REGISTRY)/peer-finder ... push: container gcloud docker -s $(REGISTRY) -- push $(PREFIX):$(TAG)

dekkagaijin · 2018-01-17T20:09:59Z

perfdash/Makefile

@@ -3,16 +3,16 @@ all: push
 # See pod.yaml for the version currently running-- bump this ahead before rebuilding!
 TAG = 0.8

-PROJ = google_containers
+REPO = k8s.gcr.io


REGISTRY = staging-k8s.gcr.io
REPO = $(REGISTRY)

...

push: container
gcloud docker -s $(REGISTRY) -- push $(REPO)/perfdash:$(TAG)

dekkagaijin · 2018-01-17T20:17:06Z

scale-demo/vegeta/Makefile


 push: container
-	gcloud docker -- push gcr.io/google_containers/loader:$(TAG)
+	gcloud docker -- push k8s.gcr.io/loader:$(TAG)


gcloud docker -s staging-k8s.gcr.io -- push staging-k8s.gcr.io/loader:$(TAG)

dekkagaijin · 2018-01-17T20:18:50Z

service-loadbalancer/Makefile

@@ -2,7 +2,7 @@ all: push

 # 0.0 shouldn't clobber any released builds
 TAG ?= 0.4
-PREFIX ?= gcr.io/google_containers/servicelb
+PREFIX ?= k8s.gcr.io/servicelb


REGISTRY ?= staging-k8s.gcr.io PREFIX ?= $(REGISTRY)/servicelb ... push: container $(GCLOUD) docker -s $(REGISTRY) -- push $(PREFIX):$(TAG)

k8s-ci-robot · 2018-01-17T21:29:01Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikedanese, MrHohn, porridge, thockin
We suggest the following additional approver: eparis

Assign the PR to them by writing /assign @eparis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2018-01-17T21:30:00Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @MrHohn @caesarxuchao @eparis @porridge @thockin

k8s-github-robot · 2018-02-01T08:02:13Z

@thockin PR needs rebase

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2017

k8s-ci-robot requested review from bowei, bprashanth, brendandburns, caesarxuchao, eparis, foxish, mikedanese, MrHohn, porridge, pwittrock and roberthbailey December 22, 2017 18:00

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 22, 2017

thockin assigned caesarxuchao, eparis and MrHohn Dec 22, 2017

MrHohn approved these changes Dec 27, 2017

View reviewed changes

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2017

porridge suggested changes Dec 28, 2017

View reviewed changes

porridge approved these changes Dec 29, 2017

View reviewed changes

k8s-ci-robot assigned porridge Dec 29, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2018

dekkagaijin suggested changes Jan 17, 2018

View reviewed changes

thockin force-pushed the gcr-vanity branch from 159324d to cdf859e Compare January 17, 2018 21:28

k8s-github-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 17, 2018

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2018

thockin added 2 commits February 1, 2018 20:38

Convert registry to k8s.gcr.io

3364659

Pushes go to staging-k8s.gcr.io

3788b30

thockin force-pushed the gcr-vanity branch from cdf859e to 3788b30 Compare February 2, 2018 04:39

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2018

thockin merged commit 2153035 into kubernetes-retired:master Feb 2, 2018

cblecker unassigned porridge, caesarxuchao, eparis and MrHohn Apr 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert registry to k8s.gcr.io #2814

Convert registry to k8s.gcr.io #2814

thockin commented Dec 22, 2017 •

edited

Loading

k8s-reviewable commented Dec 22, 2017

bowei commented Dec 22, 2017

MrHohn left a comment

porridge left a comment

thockin commented Dec 28, 2017

dekkagaijin commented Dec 28, 2017 •

edited

Loading

thockin commented Dec 28, 2017 via email

porridge left a comment

mikedanese commented Jan 2, 2018

k8s-github-robot commented Jan 13, 2018

mikedanese commented Jan 13, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

dekkagaijin Jan 17, 2018

k8s-ci-robot commented Jan 17, 2018

k8s-github-robot commented Jan 17, 2018

k8s-github-robot commented Feb 1, 2018

Convert registry to k8s.gcr.io #2814

Convert registry to k8s.gcr.io #2814

Conversation

thockin commented Dec 22, 2017 • edited Loading

k8s-reviewable commented Dec 22, 2017

bowei commented Dec 22, 2017

MrHohn left a comment

Choose a reason for hiding this comment

porridge left a comment

Choose a reason for hiding this comment

thockin commented Dec 28, 2017

dekkagaijin commented Dec 28, 2017 • edited Loading

thockin commented Dec 28, 2017 via email

porridge left a comment

Choose a reason for hiding this comment

mikedanese commented Jan 2, 2018

k8s-github-robot commented Jan 13, 2018

mikedanese commented Jan 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 17, 2018

k8s-github-robot commented Jan 17, 2018

k8s-github-robot commented Feb 1, 2018

thockin commented Dec 22, 2017 •

edited

Loading

dekkagaijin commented Dec 28, 2017 •

edited

Loading