Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

hostpath: Implement ValidateVolumeCapabilities #142

Conversation

darkowlzz
Copy link

@darkowlzz darkowlzz commented Jan 19, 2019

This implements a basic version of ValidateVolumeCapabilities for
hostpath driver and removes this from the skip tests list in the e2e
tests.

Running the e2e tests locally always failed because it was skipped for travisCI environment only.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darkowlzz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sbezverk

If they are not already assigned, you can assign the PR to them by writing /assign @sbezverk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2019
This implements a basic version of ValidateVolumeCapabilities for
hostpath driver and removes this from the skip tests list in the e2e
tests.
@pohly
Copy link
Contributor

pohly commented Jan 21, 2019

This looks like a useful enhancement. However, the hostpath driver is about to be moved to a separate repo (see kubernetes-csi/csi-driver-host-path#1), so the PR will have to be moved there once that PR is merged.

@pohly
Copy link
Contributor

pohly commented Jan 21, 2019

/hold

I'm holding this because we don't want to add any further changes here. It's still ready for review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2019
@pohly
Copy link
Contributor

pohly commented Jan 24, 2019

@darkowlzz Please move this PR over to the csi-driver-host-path repo. The code was merged into master of that repo.

@darkowlzz
Copy link
Author

Moved to kubernetes-csi/csi-driver-host-path#5.

@darkowlzz darkowlzz closed this Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants