This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Merge in (latest) upstream changes to etcd-manager #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
It has its own (separate) bazel configuration
Also add to the Makefile
Github actions provides the same signal now.
This should pick up both old images and mismatched images.
This was causing the arm64 image to not work.
Add pkg/volumes/azure.
This should make diagnostics of failed tests a little easier.
Make them easier to read as suggested in kopeio/etcd-manager#378.
justinsb
force-pushed
the
update_etcd_manager_at_20201204
branch
from
677857f
to
df770e8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully soon we can switch the primary!