-
Notifications
You must be signed in to change notification settings - Fork 133
Update dependencies before adding support for Scaleway #341
Update dependencies before adding support for Scaleway #341
Conversation
Hi @Mia-Cross. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@remyleone: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Mia-Cross, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before we can add support for Scaleway in etcd-manager (#336), we first need to update the modules, particularly kops, so that we can incorporate the changes made in this PR in the vendor directory.
The update resulted in an error with the mount.Interface so a few changes were necessary in etcd-manager/pkg/hostmount/nsenter.go