[WIP] vendor: Replace Godep with glide #1335
Conversation
|
Did you bump any deps? I'd expect this change to be transparent in term of added/removed files. |
|
Perhaps glide isn't doing the filtering based on used vs unused files, like Godep does? Do we need glide-vc? |
|
@DirectXMan12 @piosz @nhlfr as I wrote in #1314 there is no need to commit |
|
That's right. I'm going to remove the |
| @@ -8,25 +8,26 @@ SUPPORTED_KUBE_VERSIONS = "1.3.6" | |||
| TEST_NAMESPACE = heapster-e2e-tests | |||
|
|
|||
| deps: | |||
| which godep || go get github.com/tools/godep | |||
| which glide || go get github.com/Masterminds/glide | |||
| glide update | |||
|
@nhlfr can you fix the PR? it looks like the tests failed |
nhlfr
force-pushed
the
glide
branch
2 times, most recently
from
0f15bd7
to
b602f43
Compare
|
|
||
| sanitize: | ||
| hooks/check_boilerplate.sh | ||
| hooks/check_gofmt.sh | ||
| hooks/run_vet.sh | ||
|
|
||
| test-unit: clean deps sanitize build | ||
| GOOS=linux GOARCH=amd64 godep go test --test.short -race ./... $(FLAGS) | ||
| GOOS=linux GOARCH=amd64 go test --test.short -race ./... $(FLAGS) |
There was a problem hiding this comment.
should be
GOOS=linux GOARCH=amd64 go test --test.short -v -race `glide novendor` $(FLAGS)
This will prevent testing the vendored libs.
| which godep || go get github.com/tools/godep | ||
| verify-glide-installation: | ||
| which glide || go get github.com/Masterminds/glide | ||
| which glide-vc || go get github.com/sgotti/glide-vc |
There was a problem hiding this comment.
why is that needed if we are not going to commit the vendor dir?
|
Looks like glide is using raw hg to fetch a repo from bitbucket... |
|
Jenkins GCE e2e failed for commit 04895e3. Full PR test history. The magic incantation to run this job again is |
|
if im not mistaken so as godep... so why usage of hg natively here doesnt work? |
|
Probably However, I'll try to think about and propose a change to k8s infra. |
|
sounds very strange... since im pretty sure that godep required me to install hg.. |
|
ping @nhlfr |
|
I would not switch to Glide in any k8s official projects before we have done it for core (if we really want that, I'm not sure). Actually I'm in favor for committing the vendor dir into the project, because once you've downloaded the project with git, you don't have to fetch it with glide in scripts or manually. cc @thockin for thoughts on glide This will not at least make the next release, and I don't think there is any argument for doing so either. |
|
Glide still has shortcomings and is sort of in stasis until the Go
vendoring workgroup produces results. I would not swicth yet. Godep is
inscrutable, but we largely understand a way to use it that works.
…On Wed, Jan 11, 2017 at 1:32 PM, Lucas Käldström ***@***.***> wrote:
I would *not* switch to Glide in any k8s official projects before we have
done it for core (if we really want that, I'm not sure). Actually I'm in
favor for committing the vendor dir into the project, because once you've
downloaded the project with git, you don't have to fetch it with glide in
scripts or manually.
cc @thockin <https://github.com/thockin> for thoughts on glide
This will not at least make the next release, and I don't think there is
any argument for doing so either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVFCW_WdssasHTLfI9TzJFPEhmBGLks5rRUqAgaJpZM4KU0JG>
.
|
|
As I wrote in #1314 (comment), I think Heapster should follow Kubernetes standards. According to what @thockin we want to stay with godeps for a while. Once Kubernetes is migrated we will revisit this decision. Closing the PR in the meantime. |
Fixes #1314
This change is