Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Bumped supported Kubernetes version in integration tests #1394

Merged
merged 1 commit into from
Nov 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ TAG = v1.2.0
PREFIX = gcr.io/google_containers
FLAGS =

SUPPORTED_KUBE_VERSIONS = "1.3.6"
SUPPORTED_KUBE_VERSIONS = "1.4.6"
TEST_NAMESPACE = heapster-e2e-tests

deps:
Expand Down
2 changes: 1 addition & 1 deletion integration/.jenkins.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export GOBIN="$GOPATH/bin"
export PATH="$GOBIN:$PATH"

# Kubernetes version(s) to run the integration tests against.
kube_version="1.3.6"
kube_version="1.4.6"

if ! git diff --name-only origin/master | grep -c -E "*.go|*.sh|.*yaml|Makefile" &> /dev/null; then
echo "This PR does not touch files that require integration testing. Skipping integration tests!"
Expand Down
16 changes: 11 additions & 5 deletions integration/heapster_api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,15 +224,21 @@ func getSchema(fm kubeFramework, svc *kube_api.Service) (*api_v1.TimeseriesSchem
}

var expectedSystemContainers = map[string]struct{}{
"machine": {},
"kubelet": {},
"kube-proxy": {},
"system": {},
"machine": {},
"kubelet": {},
"kube-proxy": {},
// TODO(piosz): Uncomment once https://github.com/kubernetes/kubernetes/issues/37453 is fixed
// "system": {},
"docker-daemon": {},
}

func isContainerBaseImageExpected(ts *api_v1.Timeseries) bool {
_, exists := expectedSystemContainers[ts.Labels[core.LabelContainerName.Key]]
cName := ts.Labels[core.LabelContainerName.Key]
// TODO(piosz): remove this if once https://github.com/kubernetes/kubernetes/issues/37453 is fixed
if cName == "system" {
return false
}
_, exists := expectedSystemContainers[cName]
return !exists
}

Expand Down
2 changes: 1 addition & 1 deletion metrics/sinks/manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestAllExportsInTime(t *testing.T) {
manager.ExportData(&batch)

elapsed := time.Now().Sub(now)
if elapsed > 2*timeout+2*time.Second {
if elapsed > 3*timeout+2*time.Second {
t.Fatalf("3xExportData took too long: %s", elapsed)
}

Expand Down