Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Missing git history from coreos-kubernetes/tree/master/multi-node/aws #3

Closed
kenden opened this issue Oct 20, 2016 · 5 comments
Closed

Comments

@kenden
Copy link

kenden commented Oct 20, 2016

The first commit message in this repo says:
"Move everything under the multi-node/aws directory from coreos/coreos-kubernetes c25ac21"

But all the commit history from the original location is lost
https://github.com/coreos/coreos-kubernetes/tree/master/multi-node/aws

Could you maybe extract the directory's history?
http://stackoverflow.com/questions/1662753/export-subtree-in-git-with-history

Also, should https://github.com/coreos/coreos-kubernetes/tree/master/multi-node/aws be stopped/blocked if this repo is to become the official location?

@mumoshu
Copy link
Contributor

mumoshu commented Oct 21, 2016

Hi @kenden
Thanks for your feedback!

I've just finished recovering the history with the procedure you've provided.

It does seem to work but a gotcha(at least for me) is that, even though it doesn't relate to the procedure, each directory's history doesn't survive git mv so e.g. looking into config/'s history, you'll see that the origin of it is now my git mv commit https://github.com/coreos/kube-aws/commits/master/config
However, the root directory's history is preserved as we might have expected https://github.com/coreos/kube-aws/commits/master so I assume it is still very useful.

Are you satisfied to the result?
Further comments and feedbacks are welcome!

Also, regarding the former repo, would you please wait until coreos guys make an announcement?

@kenden
Copy link
Author

kenden commented Oct 21, 2016

Much nicer thanks @mumoshu!
Note it's still possible to get the history of files under config with for ex:git log --follow config/config.go.
Cheers!

@mumoshu
Copy link
Contributor

mumoshu commented Oct 26, 2016

@kenden I wasn't aware of it but --follow did work. Thanks for the tip!

@mumoshu
Copy link
Contributor

mumoshu commented Nov 9, 2016

@kenden FYI regarding the former repo, coreos/coreos-kubernetes#751 is WIP

@mumoshu
Copy link
Contributor

mumoshu commented Nov 18, 2016

I guess you've probably noticed that the move from the coreos-kubernetes to the kube-aws repo is announced multiple times in github issues. There's also a notice in the very beginning of the README 👍

I'm closing this as the original issues are resolved but feel free to reopen if necessary.
Thanks for your interest and feedback, @kenden!

@mumoshu mumoshu closed this as completed Nov 18, 2016
tyrannasaurusbanks pushed a commit to tyrannasaurusbanks/kube-aws that referenced this issue Apr 19, 2017
…RUN-343-userdata-fingerprint to hcom-flavour

* commit '0628bedf91b8901b8d220c2e7368b12b84769798':
  Repair CF rollbacks to work after the S3 userdata improvement Fixes kubernetes-retired#352
mumoshu pushed a commit that referenced this issue May 10, 2018
dominicgunn added a commit that referenced this issue Sep 16, 2020
Co-authored-by: Kevin Richardson <[email protected]>
Co-authored-by: Dominic Gunn <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants