This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Experimental feature: Spot Fleet support for worker nodes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 66.06% (diff: 96.61%)@@ master #113 diff @@
==========================================
Files 4 5 +1
Lines 934 993 +59
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 599 656 +57
- Misses 254 255 +1
- Partials 81 82 +1
|
7 tasks
|
@c-knowles FYI I've introduced our first test suite which does integration testing with real AWS services including S3, KMS, CloudFormation as we've discussed before |
mumoshu
commented
Dec 5, 2016
| spec.RootVolumeType = c.WorkerRootVolumeType | ||
| } | ||
| if spec.RootVolumeSize == 0 { | ||
| spec.RootVolumeSize = c.WorkerRootVolumeSize * spec.WeightedCapacity |
There was a problem hiding this comment.
I'd rather like to make this computed via c.WorkerSpotFleet.UnitRootVolumeSize * spec.WeightedCapacity while adding UnitRootVolumeSize to the SpotFleet struct, so that we can be more explicit that it is not the exact size of EBS volumes but size per "unit".
// Thanks for the initial comment/proposal on this @everpeace!
|
E2E tests passed |
… rendered from stack-template.json templates
mumoshu
force-pushed
the
spot-fleet-for-workers
branch
from
e8d8e5c
to
c43f41b
Compare
- fix typo of `nodepools' with correct `node-pools`
See updated nodepool/config/templates/cluster.yaml for the detailed guide of configuration. This is the initial implementation for kubernetes-retired#112 Beware that this feature may change in backward-incompatible ways
…loudFormation Integration tests are executed only when you've explicitly set non-empty value for the environment variable KUBE_AWS_INTEGRATION_TEST. Also note that these tests pass only when other environment variables referenced in `test/integration/aws_test.go` are properly set.
mumoshu
force-pushed
the
spot-fleet-for-workers
branch
from
c43f41b
to
d94e129
Compare
|
Rebased and then squashed. |
|
All green. Merging 🚥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #112