This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Correct node pool command inconsistencies #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Yes, Also, would you mind fixing README.md and |
Update existing references and add render to Documentation
|
@mumoshu render for node pools was actually missing from the documentation so I added it. |
Current coverage is 69.36% (diff: 100%)@@ master #174 diff @@
==========================================
Files 4 4
Lines 1126 1126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 781 781
Misses 259 259
Partials 86 86
|
|
LGTM 👍 Thanks as always 🙇 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…nsistencies Correct node pool command inconsistencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects one of my comments from #44 now we actually have the node pool validation. I'm not sure we even need the
runCmdRendermethod as isn'tkube-aws node-pool renderwithout any subcommand already deprecated? We shouldn't add deprecated things so if we want it to always bekube-aws node-pool render stackthen I think we remove this part entirely.