Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Metrics Server addon. #973

Merged
merged 3 commits into from
Nov 24, 2017
Merged

Metrics Server addon. #973

merged 3 commits into from
Nov 24, 2017

Conversation

camilb
Copy link
Contributor

@camilb camilb commented Oct 10, 2017 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2017
@codecov-io
Copy link

codecov-io commented Oct 10, 2017 •
edited
Loading

Codecov Report

Merging #973 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   34.91%   34.92%   +0.01%     
==========================================
  Files          59       59              
  Lines        4159     4160       +1     
==========================================
+ Hits         1452     1453       +1     
  Misses       2545     2545              
  Partials      162      162
Impacted Files Coverage Δ
core/controlplane/config/config.go 58.41% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7cec8...d269833. Read the comment docs.

@danielfm
Copy link
Contributor

What about heapster? Can this add-on run alongside heapster in such a way we can migrate to it in a safe manner?

@camilb
Copy link
Contributor Author

camilb commented Oct 12, 2017

Didn't have time to investigate it further, made a quick test in parallel with heapster in k8s 1.8 and works fine. kubectl top is one of the components that should use the new metrics-server but it didn't work without heapster.

@mumoshu
Copy link
Contributor

mumoshu commented Oct 14, 2017

@camilb Thanks for the contribution 👍
This is conflicting with your latest work which has just been merged 😢
Otherwise, LGTM.

@mumoshu
Copy link
Contributor

mumoshu commented Nov 22, 2017

@camilb I've resolved conflicts just now. Can we remove the WIP in the subject and merge this?

@camilb camilb changed the title [WIP] Metrics Server addon. Metrics Server addon. Nov 22, 2017
@mumoshu mumoshu merged commit 57f420c into kubernetes-retired:master Nov 24, 2017
@mumoshu
Copy link
Contributor

mumoshu commented Nov 24, 2017

@camilb Thanks for contributing!

@mumoshu mumoshu added this to the v0.9.9 milestone Nov 24, 2017
redbaron
redbaron reviewed Nov 24, 2017
View reviewed changes
core/controlplane/config/templates/cloud-config-controller
serviceAccountName: metrics-server
containers:
- name: metrics-server
image: gcr.io/google_containers/metrics-server-amd64:v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't image be templated from a value from cluster.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed in #1035

camilb added a commit to camilb/kube-aws that referenced this pull request Nov 24, 2017
@camilb
Merge remote-tracking branch 'kubernetes-incubator/master'
a25e085 
* kubernetes-incubator/master:
  Follow-ups for Kubernetes 1.8
  Metrics Server addon. (kubernetes-retired#973)
  Update Tiller image to v2.7.2
  Update kube-dns 1.14.7
  Bump Cluster Autoscaler version to 1.0.3
  Bump Kubernetes and ETCD version.
  Update RBAC API version to v1 from v1beta1
@camilb camilb mentioned this pull request Nov 24, 2017
Merged
@mumoshu mumoshu mentioned this pull request Nov 27, 2017
Closed
davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 21, 2018
Merge pull request kubernetes-retired#27 in RUN/kube-aws from hcom-fl…
f40e443 
…avour-0.9.9 to hcom-flavour

* commit '0e116d72ead70121c730d3bc4009f8d562e16912': (24 commits)
  RUN-788 Add kubectl run parameters
  Allow toggling Metrics Server installation
  Correct values for the `kubernetes.io/cluster/<Cluster ID>` tags Resolves kubernetes-retired#1025
  Fix dashboard doco links
  Fix install-kube-system when node drainer is enabled Follow-up for kubernetes-retired#1043
  Two fixes to 0.9.9 rc.3 (kubernetes-retired#1043)
  Update the documentation for Kubernetes Dashboard.
  Improve the configuration for Kubernetes Dashboard.
  Fix the creation of all metrics-server resources.
  Use templated image for metrics-server.
  Follow-ups for Kubernetes 1.8
  Metrics Server addon. (kubernetes-retired#973)
  Quick start and high availability guides
  Add rkt container cleanup to journald-cloudwatch-logs service
  Update Tiller image to v2.7.2
  Update kube-dns 1.14.7
  Bump Cluster Autoscaler version to 1.0.3
  Bump Kubernetes and ETCD version.
  Support EC2 instance tags per node role This feature will be handy when e.g. your monitoring tools discovers EC2 instances and then groups resource metrics with EC2 instance tags.
  Fix the default FleetIamRole Closes kubernetes-retired#1022
  ...
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
@camilb @mumoshu
Metrics Server addon. (kubernetes-retired#973)
9707e11 
More info here:
https://kubernetes.io/docs/tasks/debug-application-cluster/core-metrics-
pipeline/
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@redbaron redbaron redbaron left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9.9-rc.4
Development

Successfully merging this pull request may close these issues.
6 participants
@camilb @codecov-io @danielfm @mumoshu @redbaron @k8s-ci-robot