Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

pkg/controller/webhook.Validate et al should return an AdmissionResponse #1267

Closed
makkes opened this issue Aug 5, 2020 · 1 comment · Fixed by #1282
Closed

pkg/controller/webhook.Validate et al should return an AdmissionResponse #1267

makkes opened this issue Aug 5, 2020 · 1 comment · Fixed by #1282
Assignees
@makkes
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@makkes
Copy link
Contributor

makkes commented Aug 5, 2020 •
edited
Loading

What would you like to be added:
The functions in pkg/controller/webhook/util.go should not mutate the admission.Response parameter but rather return a new one.

Why is this needed:
This came out of this PR review.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 5, 2020
@makkes makkes mentioned this issue Aug 5, 2020
Merged
@makkes
Copy link
Contributor Author

makkes commented Sep 21, 2020

/assign

@makkes makkes mentioned this issue Sep 22, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@makkes makkes

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: webhook functions now return AdmissionResponse makkes/kubefed
2 participants
@makkes @k8s-ci-robot