This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: webhook functions now return AdmissionResponse #1282
+91
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I'll have to have a look at the failing tests as well. |
|
Ok, failing test was just caused by the linter. |
k8s-ci-robot
added
size/L
|
I guess commit should be squashed, otherwise, LGTM. |
Having these functions modify the AdmissionResponse passed in as parameter makes it hard to reason about the code. controller.webhook.util.Unmarshal was removed for the sake of not having to return nil in case of success. This adds a bit more code to the calling functions but at the same time helps bring across the intended behaviour.
makkes
force-pushed
the
return-admissionresponse
branch
from
3697ff5
to
01e60d9
Compare
|
commits are squashed now. |
|
/lgtm |
|
/approve Thanks @makkes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Having these functions modify the AdmissionResponse passed in as
parameter makes it hard to reason about the code.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1267
Special notes for your reviewer: