Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Controller runtime 0.5.0 #1184

Merged

Conversation

jimmidyson
Copy link
Contributor

What this PR does / why we need it:
This PR switches to using go modules with latest go 1.13.

This PR also upgrades to Kubernetes 1.17.3 dependencies and controller-runtime 0.5.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #778

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2020
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2020
@pmorie
Copy link
Contributor

pmorie commented Feb 17, 2020

/lgtm /approve

@jimmidyson jimmidyson changed the title Controller runtime 0.4.0 Controller runtime 0.5.0 Feb 18, 2020
@jimmidyson
Copy link
Contributor Author

/assign @font

@hectorj2f
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@hectorj2f: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gyliu513
Copy link
Contributor

/lgtm

FYI @xunpan for approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@pmorie
Copy link
Contributor

pmorie commented Feb 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4ceec91 into kubernetes-retired:master Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to go modules for dependancy management
7 participants