-
Notifications
You must be signed in to change notification settings - Fork 531
chore: serve controller default metrics #1193
chore: serve controller default metrics #1193
Conversation
dfd97eb
to
f895732
Compare
f895732
to
3bb0e27
Compare
Thanks for doing this! LGTM, but you need to resolve the merge conflict first. |
3bb0e27
to
f869991
Compare
@pmorie I rebased it against master. Thanks for taking a look at the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a note that this should migrate to use controller-runtime in future iterations imo.
/lgtm |
/approve |
@jimmidyson yeah, that would be awesome. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR exposes default controller metrics and makes both
healthz-addr
andmetrics-addr
configurable via flags.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
In addition to this PR, I have prepared another work which adds kubefed custom metrics to certain actions which will give us a better view of future bottleneck of scalability issues.