Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

chore: serve controller default metrics #1193

Merged

Conversation

hectorj2f
Copy link
Contributor

What this PR does / why we need it:

This PR exposes default controller metrics and makes both healthz-addr and metrics-addr configurable via flags.

rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.001"} 33
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.002"} 156
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.004"} 606
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.008"} 1779
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.016"} 2057
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.032"} 2061
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.064"} 2129
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.128"} 2387
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.256"} 2388
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="0.512"} 2388
rest_client_request_latency_seconds_bucket{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET",le="+Inf"} 2388
rest_client_request_latency_seconds_sum{url="https://10.0.0.1:443/%7Bprefix%7D",verb="GET"} 34.46997236000008

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

In addition to this PR, I have prepared another work which adds kubefed custom metrics to certain actions which will give us a better view of future bottleneck of scalability issues.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2020
@pmorie
Copy link
Contributor

pmorie commented Feb 25, 2020

Thanks for doing this! LGTM, but you need to resolve the merge conflict first.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020
@hectorj2f
Copy link
Contributor Author

@pmorie I rebased it against master. Thanks for taking a look at the PR.

Copy link
Contributor

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a note that this should migrate to use controller-runtime in future iterations imo.

@jimmidyson
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@jimmidyson
Copy link
Contributor

/approve

@hectorj2f
Copy link
Contributor Author

LGTM, with a note that this should migrate to use controller-runtime in future iterations imo.

@jimmidyson yeah, that would be awesome.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, jimmidyson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9271f47 into kubernetes-retired:master Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants