-
Notifications
You must be signed in to change notification settings - Fork 531
chore: make cluster creation work with kind v0.7.0 #1221
chore: make cluster creation work with kind v0.7.0 #1221
Conversation
Welcome @makkes! |
/assign @irfanurrehman |
550a381
to
eda2aea
Compare
eda2aea
to
3dcf807
Compare
tests are failing for a reason that's not totally obvious to me. I'll have to have a further look. |
@makkes Absolutely appreciate you doing this. Does the same run fine locally for you ? |
@irfanurrehman, thanks for the feedback. To answer your question: Not yet, as I had to figure out which tests are being run by Travis. Now I got everything set up and I can reproduce the failure. Fix incoming. This is slightly larger than I thought initially. 😌 |
@irfanurrehman, all tests pass locally now. 🤦♂️ 🤣 |
@makkes nice, I will give it a try myself. |
I created #1223 to track kind v0.8 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makkes please, clean the commit log. The code looks good to me.
The command 'kind get kubeconfig-path' has been deprecated in kind v0.6.0 and removed in v0.7.0 so the cluster creation script doesn't work with the latter version. To account for this fact and other changes (such as kind now respecting `KUBECONFIG` and falling back to the same defaults that `kubectl` uses), I reworked some parts of the script. pre-commit now uses the kind imave v1.17.5 for tests. Note: This change makes the scripts fail to work with kind version < v0.7.0.
da26ee8
to
27df67b
Compare
@hectorj2f, I squashed all commits into one. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@makkes @hectorj2f. Apologies for not getting to this earlier. I had a glance at this over the weekend and was supposed to spend time on this today. Anywhichways, I am curious if you did verify that the scripts work on mac? |
@irfanurrehman I tested on Linux where I have my setup. But I am not sure if it ever worked on OSX out of the box. |
@hectorj2f you are right, it did not work out of the box for OSX. I was hoping that with the updated kind version, it might. |
@irfanurrehman that might be a simple bug fix. I will take a look at it. |
@irfanurrehman, @hectorj2f, making |
@makkes we use The tricky part to take care however is that the apiserver endpoint differs depending on where you are accessing the cluster from. If you access one kind cluster from within another, you need to use the container internal ip (which cannot be reached from local machine) whereas when you access it from local machine (for example the scripts and what is stored in the kubeconfig) it is Having said that, I think we can live with what we currently have.. :) |
@irfanurrehman, this is true for the kind cluster but So |
Aah yes! I was missing that part. As I said earlier, I think we can live with what we currently have.. :) |
Meanwhile thanks @makkes for doing this! |
What this PR does / why we need it:
The command 'kind get kubeconfig-path' has been deprecated in kind
v0.6.0 and removed in v0.7.0 so the cluster creation script doesn't
work with the latter version. To account for this fact and other
changes (such as kind now respecting
KUBECONFIG
and falling back tothe same defaults that
kubectl
uses), I reworked some parts of thescript.
pre-commit now uses the kind imave v1.17.5 for tests.
Note: This change makes the scripts fail to work with
kind version < v0.7.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1220
Special notes for your reviewer: