chore: make cluster creation work with kind v0.7.0

[makkes]

What this PR does / why we need it:
The command 'kind get kubeconfig-path' has been deprecated in kind
v0.6.0 and removed in v0.7.0 so the cluster creation script doesn't
work with the latter version. To account for this fact and other
changes (such as kind now respecting KUBECONFIG and falling back to
the same defaults that kubectl uses), I reworked some parts of the
script.

pre-commit now uses the kind imave v1.17.5 for tests.

Note: This change makes the scripts fail to work with
kind version < v0.7.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1220

Special notes for your reviewer:

[k8s-ci-robot]

Welcome @makkes!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[makkes]

/assign @irfanurrehman

[makkes]

tests are failing for a reason that's not totally obvious to me. I'll have to have a further look.

[irfanurrehman]

@makkes Absolutely appreciate you doing this. Does the same run fine locally for you ?

[makkes]

@makkes Absolutely appreciate you doing this. Does the same run fine locally for you ?

@irfanurrehman, thanks for the feedback.

To answer your question: Not yet, as I had to figure out which tests are being run by Travis. Now I got everything set up and I can reproduce the failure. Fix incoming. This is slightly larger than I thought initially. 😌

[makkes]

@irfanurrehman, all tests pass locally now. 🤦‍♂️ 🤣

[hectorj2f]

@makkes nice, I will give it a try myself.

[makkes]

I created #1223 to track kind v0.8 support.

[hectorj2f]

/lgtm

[hectorj2f]

@makkes please, clean the commit log. The code looks good to me.

[makkes]

@hectorj2f, I squashed all commits into one.

[hectorj2f]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, makkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hectorj2f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hectorj2f]

/lgtm

[irfanurrehman]

@makkes @hectorj2f. Apologies for not getting to this earlier. I had a glance at this over the weekend and was supposed to spend time on this today. Anywhichways, I am curious if you did verify that the scripts work on mac?

[hectorj2f]

@irfanurrehman I tested on Linux where I have my setup. But I am not sure if it ever worked on OSX out of the box.

[irfanurrehman]

@irfanurrehman I tested on Linux where I have my setup. But I am not sure if it ever worked on OSX out of the box.

@hectorj2f you are right, it did not work out of the box for OSX. I was hoping that with the updated kind version, it might.

[hectorj2f]

@irfanurrehman that might be a simple bug fix. I will take a look at it.

[makkes]

@irfanurrehman, @hectorj2f, making create-clusters.sh work with an insecure registry on macOS might be a slightly bigger effort as Docker for Mac runs inside of a VM so you can't easily change the daemon cfg.

[irfanurrehman]

@irfanurrehman, @hectorj2f, making create-clusters.sh work with an insecure registry on macOS might be a slightly bigger effort as Docker for Mac runs inside of a VM so you can't easily change the daemon cfg.

@makkes we use docker exec to update the config and I think it behaves the same on OSX irrespective of where the container is actually running (Am I missing something?).

The tricky part to take care however is that the apiserver endpoint differs depending on where you are accessing the cluster from. If you access one kind cluster from within another, you need to use the container internal ip (which cannot be reached from local machine) whereas when you access it from local machine (for example the scripts and what is stored in the kubeconfig) it is 127.0.0.1:<some unique port>. This is different from linux and workaround(s) becomes a little hacky.

Having said that, I think we can live with what we currently have.. :)

[makkes]

we use docker exec to update the config

@irfanurrehman, this is true for the kind cluster but create-clusters.sh also changes the host's docker daemon config if CONFIGURE_INSECURE_REGISTRY_HOST is set to true:
https://github.com/kubernetes-sigs/kubefed/blob/ab94a922ef079329f86fa80b1ae220cb5c3cb15d/scripts/create-clusters.sh#L70
which is the case in pre-commit.sh:
https://github.com/kubernetes-sigs/kubefed/blob/ab94a922ef079329f86fa80b1ae220cb5c3cb15d/scripts/pre-commit.sh#L153

So create-clusters.sh works on macOS (if you don't provide the CONFIGURE_INSECURE_REGISTRY_HOST flag) while pre-commit.sh doesn't.

[irfanurrehman]

Aah yes! I was missing that part. As I said earlier, I think we can live with what we currently have.. :)

[irfanurrehman]

Meanwhile thanks @makkes for doing this!