Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

ingress-nginx master changed, so use nginx-0.32.0 #1228

Merged
merged 2 commits into from
May 19, 2020

Conversation

pacoxu
Copy link
Contributor

@pacoxu pacoxu commented May 11, 2020

What this PR does / why we need it:

use old tag of ingress nginx repo
https://github.com/kubernetes/ingress-nginx/tree/nginx-0.22.0/deploy

master branch:
https://github.com/kubernetes/ingress-nginx/tree/master/deploy

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[root@xxx-10-6-177-41 ~]# kubectl --context paco308 apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/mandatory.yaml
error: unable to read URL "https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/mandatory.yaml", server reported 404 Not Found, status code=404

Special notes for your reviewer:

Or you will get 404 error like above

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @pacoxu!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2020
@xunpan
Copy link
Contributor

xunpan commented May 13, 2020

@pacoxu
Thanks for finding this issue. I think it works. Could you please add comments about the reason to use version 0.22.0?

@pacoxu
Copy link
Contributor Author

pacoxu commented May 14, 2020

kubernetes/ingress-nginx#4055

After 0.25.0, it changed the file path.

kubectl create ns ingress-nginx
kubectl apply -k github.com/kubernetes/ingress-nginx/deploy/base

or

according to https://kubernetes.github.io/ingress-nginx/deploy/, we may use the latest version

kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-0.32.0/deploy/static/provider/cloud/deploy.yaml

@xunpan
Copy link
Contributor

xunpan commented May 14, 2020

Thanks for your explaination.
To me, nginx version makes less sense for our example here. So, any working version is fine.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020
@pacoxu pacoxu changed the title ingress-nginx master changed, so use nginx-0.22.0 ingress-nginx master changed, so use nginx-0.32.0 May 19, 2020
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 00348bb into kubernetes-retired:master May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants