Infinite reconciliation loop (rawstatuscollection)

[cebernardi]

What this PR does / why we need it:
Federated resources that have target resources without status field are constantly evaluated as "changed", if RawStatusCollection is Enabled. This triggers an infinite loop when multiple FederatedResources are created at the same time in the cluster.
Also, this PR applies to collectedStatuses the same transformation that is applied to the FederatedResource status (json.Marshal - json.Unmarshall), so to prevent avoidable changes (and reconciliations) to the FederatedResources.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1373

Special notes for your reviewer:

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hectorj2f]

@cebernardi Did you manage to figure it out the issue with the tests ?

[cebernardi]

@cebernardi Did you manage to figure it out the issue with the tests ?

tests are failing because of

1.15.3: Pulling from library/golang
 library/golang
docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

I'm trying to retrigger the build..

[hectorj2f]

@cebernardi I can do that for you.

[cebernardi]

@cebernardi I can do that for you.

yes please @hectorj2f ...
It just failed again for the same reason...

[hectorj2f]

@cebernardi Done, we now need you to sign the cla.

[cebernardi]

@hectorj2f let me check with my company, they should have already signed it, and they might be in the process of returning it.. will let you know asap

[cebernardi]

@hectorj2f the CLA is signed.. is there a way to trigger again the check?

[hectorj2f]

@cebernardi No, I don't know it. Perhaps close-and-reopen the PR. I am not sure.

[cebernardi]

/check-cla

[cebernardi]

double checked again.. CLA was signed BUT not returned to Linux Foundation..

[hectorj2f]

/check-cla

[swiftslee]

Too many commits. I think you need to merge the commits into one.

[hectorj2f]

@cebernardi i tested your changes and they work. We need a proper commit log, and address your signing issues.

[hectorj2f]

/check-cla

[hectorj2f]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cebernardi, hectorj2f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hectorj2f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hectorj2f]

/lgtm