-
Notifications
You must be signed in to change notification settings - Fork 531
feat:Use patch to replace update in generic client for multi cases #1409
feat:Use patch to replace update in generic client for multi cases #1409
Conversation
Welcome @qmhu! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5878540
to
4c2a541
Compare
ci failed @qmhu |
/retest |
@hectorj2f could you retest the ci? Thank you so much. |
b576922
to
c9a62ff
Compare
@font @gyliu513 @mars1024 @hectorj2f cloud you review this pr? tks |
ref to #1394 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, qmhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As issue #1389 , replaced Update in remained codes
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1394
Special notes for your reviewer: