Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Update runtime-controller v0.21.2 to v0.22.2 #1492

Merged
merged 2 commits into from
May 10, 2022

Conversation

tehlers320
Copy link
Contributor

@tehlers320 tehlers320 commented Feb 16, 2022

What this PR does / why we need it:
To fix #1488

Which issue(s) this PR fixes:
Fixes #
#1488
NOTE: per cluster, per resource rest metrics are now gone (a decision by upstream module maintainers)

So for example these metrics:

rest_client_request_latency_seconds_bucket{url="https://10.11.11.11:5009/apis/coordination.k8s.io/v1?timeout=32s",verb="GET",le="0.512"} 12
rest_client_request_latency_seconds_bucket{url="https://10.11.11.115009/apis/coordination.k8s.io/v1?timeout=32s",verb="GET",le="+Inf"} 12

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2022
@tehlers320 tehlers320 changed the title Update from v0.21.2 to v0.23.2 WIP Update from v0.21.2 to v0.23.2 Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022
@tehlers320
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2022
@irfanurrehman
Copy link
Contributor

@tehlers320 try signing/authorising the CLA again from the link in this comment, please. If that does not resolve the issue in this PR and you sure you have signed/authorised the same, try opening a new PR. Signed CLA might be a prerequesite, rather then it being in flight for the check to pass in the PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 8, 2022
@tehlers320 tehlers320 closed this Mar 17, 2022
@tehlers320 tehlers320 reopened this May 6, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 6, 2022
@tehlers320 tehlers320 changed the title WIP Update from v0.21.2 to v0.23.2 WIP Update from v0.21.2 to v0.22.2 May 9, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2022
@tehlers320
Copy link
Contributor Author

tehlers320 commented May 9, 2022

controller 0.8.1 with 10 clusters and 3000 federated resources
Screen Shot 2022-05-09 at 10 12 24 AM

this PR with 10 clusters and 3000 federated resources
Screen Shot 2022-05-09 at 10 11 44 AM

@tehlers320 tehlers320 changed the title WIP Update from v0.21.2 to v0.22.2 Update from v0.21.2 to v0.22.2 May 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2022
@tehlers320 tehlers320 changed the title Update from v0.21.2 to v0.22.2 Update runtime-controller v0.21.2 to v0.22.2 May 9, 2022
@tehlers320
Copy link
Contributor Author

/assign @hectorj2f

@irfanurrehman
Copy link
Contributor

Thanks @tehlers320 for resurrecting this and posting the test results.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@irfanurrehman
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irfanurrehman, tehlers320

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@irfanurrehman
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 44c3be4 into kubernetes-retired:master May 10, 2022
@tehlers320 tehlers320 deleted the conroller_0_11_0 branch May 12, 2022 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics volume is un-sustainable.
4 participants