This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
build: Use KinD for syncing helm chart resources #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was using kubebuilder provided API server and etcd, but these were very out of date (k8s v1.16), leading to potentially out of date resources and difficulties upgrading to later APIs that were not available in v1.16 (e.g. `networking.k8s.io/v1`). This commit fixes this by using KinD as the cluster to discover resources to sync to the Helm chart.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
makkes
reviewed
Aug 9, 2022
There was a problem hiding this comment.
I'm not sure if any of the documentation is affected by this and I don't have the time to verify it. If you would mind checking this @jimmidyson, please? Otherwise lgtm.
|
Hi @makkes. This doesn't affect the docs but it reminds me that the next PR does so I'll update docs in there. |
makkes
approved these changes
Aug 9, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was using kubebuilder provided API server and etcd, but these were very out of date (k8s v1.16), leading to potentially out of date resources and difficulties upgrading to later APIs that were not available in v1.16 (e.g.
networking.k8s.io/v1).This commit fixes this by using KinD as the cluster to discover resources to
sync to the Helm chart.