Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: Move ingress from extensions/v1beta1 to networking.k8s.io/v1 #1521

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

jimmidyson
Copy link
Contributor

extensions/v1beta1 was deprecated in v1.14,
networking.k8s.io/v1beta1 was deprecated in v1.19 so this commit moves
straight to networking.k8s.io/v1 which has been available since v1.19.
Considering k8s is now at v1.24.3 this is a sufficient compatibility
window.

`extensions/v1beta1` was deprecated in v1.14,
`networking.k8s.io/v1beta1` was deprecated in v1.19 so this commit moves
straight to `networking.k8s.io/v1` which has been available since v1.19.
Considering k8s is now at v1.24.3 this is a sufficient compatibility
window.
@jimmidyson jimmidyson requested a review from makkes August 9, 2022 12:12
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2022
@irfanurrehman
Copy link
Contributor

Thanks for doing this @jimmidyson
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irfanurrehman, jimmidyson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [irfanurrehman,jimmidyson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a723d2 into kubernetes-retired:master Aug 10, 2022
@jimmidyson jimmidyson deleted the ingress-v1 branch August 10, 2022 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants