This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: Move ingress from extensions/v1beta1 to networking.k8s.io/v1 #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extensions/v1beta1` was deprecated in v1.14, `networking.k8s.io/v1beta1` was deprecated in v1.19 so this commit moves straight to `networking.k8s.io/v1` which has been available since v1.19. Considering k8s is now at v1.24.3 this is a sufficient compatibility window.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Thanks for doing this @jimmidyson |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extensions/v1beta1was deprecated in v1.14,networking.k8s.io/v1beta1was deprecated in v1.19 so this commit movesstraight to
networking.k8s.io/v1which has been available since v1.19.Considering k8s is now at v1.24.3 this is a sufficient compatibility
window.