Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Make ConfigReconciler watches for custom resources #514

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Make ConfigReconciler watches for custom resources #514

merged 1 commit into from
Mar 12, 2020

Conversation

sophieliu15
Copy link
Contributor

@sophieliu15 sophieliu15 commented Mar 11, 2020 •
edited
Loading

This PR makes ConfigReconciler watches for custom resources and triggers reconciliation of the config singleton when any custom resource is created/updated.

Tested: unit tests, GKE cluster

closes #488

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 11, 2020
@sophieliu15
Copy link
Contributor Author

/assign @adrianludwin
/assign @yiqigao217

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 11, 2020
@sophieliu15 sophieliu15 mentioned this pull request Mar 11, 2020
Closed
adrianludwin
adrianludwin reviewed Mar 11, 2020
View reviewed changes
incubator/hnc/cmd/manager/main.go Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/hnc_config.go Outdated Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/hnc_config.go Outdated Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/hnc_config_test.go Outdated Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/hnc_config_test.go Outdated Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/hnc_config_test.go Outdated Show resolved Hide resolved
incubator/hnc/pkg/reconcilers/test_helpers_test.go Outdated Show resolved Hide resolved
@sophieliu15
Make ConfigReconciler watches for custom resources
e459641 
This PR makes ConfigReconciler watches for custom resources and triggers reconciliation of the config singleton when any custom resource is created/updated.

Tested: unit tests, GKE cluster

part of kubernetes-retired#488
adrianludwin
adrianludwin reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold
/assign @rjbez17

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2020
@rjbez17
Copy link

rjbez17 commented Mar 12, 2020

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17, sophieliu15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e15437f into kubernetes-retired:master Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjbez17 rjbez17 rjbez17 left review comments

@adrianludwin adrianludwin adrianludwin left review comments

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@srampal srampal Awaiting requested review from srampal

Assignees

@rjbez17 rjbez17

@adrianludwin adrianludwin

@yiqigao217 yiqigao217

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HNC: Avoid restart HNC after adding a new CRD
5 participants
@sophieliu15 @rjbez17 @k8s-ci-robot @adrianludwin @yiqigao217