chore: change observe time unit to seconds

kubernetes-sigs · Aug 29, 2024 · 438034b · 438034b
1 parent c688fbe
commit 438034b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/common/volume_stats_controllerserver.go b/pkg/common/volume_stats_controllerserver.go
@@ -26,7 +26,7 @@ func (cs *ControllerServerWithMetricRecorder) observeExecTime(time int64, statTy
 		metric.VolumeStatTypeLabelName:    cs.driverType,
 		metric.VolumeStatIdLabelName:      volumeId,
 		metric.VolumeStatErrCodeLabelName: errCode,
-	}).Observe(float64(time))
+	}).Observe(float64(time) / 1000)
 }
 
 func getCodeFromError(err error) codes.Code {

diff --git a/pkg/common/volume_stats_nodeserver.go b/pkg/common/volume_stats_nodeserver.go
@@ -47,7 +47,7 @@ func (ns *NodeServerWithMetricRecorder) observeExecTime(time int64, statType met
 		metric.VolumeStatTypeLabelName:    ns.driverType,
 		metric.VolumeStatIdLabelName:      volumeId,
 		metric.VolumeStatErrCodeLabelName: errCode,
-	}).Observe(float64(time))
+	}).Observe(float64(time) / 1000)
 }
 
 func (ns *NodeServerWithMetricRecorder) observeVolumeAttachmentTime(curTime int64, req *csi.NodePublishVolumeRequest, err error) {
@@ -75,7 +75,7 @@ func (ns *NodeServerWithMetricRecorder) observeVolumeAttachmentTime(curTime int6
 		metric.VolumeStatTypeLabelName:    ns.driverType,
 		metric.VolumeStatIdLabelName:      req.GetVolumeId(),
 		metric.VolumeStatErrCodeLabelName: errCode,
-	}).Observe(float64(curTime) - float64(podStartTime))
+	}).Observe((float64(curTime) - float64(podStartTime)) / 1000)
 }
 
 func getPodStartTimestamp(pod *v1.Pod) (int64, error) {