Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support set nfs readahead in PV attributes #1162

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support set nfs readahead in PV attributes #1162

wants to merge 3 commits into from

Conversation

tydra-wang
Copy link
Contributor

@tydra-wang tydra-wang commented Sep 6, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

1. Support setting nfs readahead in the volumeAttributes of NAS PV like 'sysConfig: bdi/read_ahead_kb=2048'.
2. Restrict disk sysConfig keys to those with the prefix 'queue/'.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tydra-wang
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2024
huww98
huww98 reviewed Sep 9, 2024
View reviewed changes
pkg/disk/nodeserver.go Outdated Show resolved Hide resolved
pkg/nas/utils.go
// nfs-utils versions later than nfs-utils-2.3.3-57.0.1.al8.1 have udev rules for nfsrahead enabled,
// which automatically set a default read_ahead_kb after the bdi subsystem add event.
// To avoid conflicts, we need to introduce a delay and then recheck our custom settings.
time.Sleep(time.Second * 2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fighting with udev. Maybe we should find a better way.

pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
pkg/nas/nodeserver.go Outdated Show resolved Hide resolved
pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
pkg/disk/nodeserver.go Outdated Show resolved Hide resolved
pkg/utils/io/sysconfig.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huww98 huww98 huww98 left review comments

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tydra-wang @k8s-ci-robot @huww98