Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk-snapshot: support volume group snapshot APIs #1176

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

disk-snapshot: support volume group snapshot APIs #1176

wants to merge 11 commits into from

Conversation

AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented Sep 26, 2024

This PR will:

  1. bump snapshot client version from v4 to v8 and add default volumegroupsnapshotclass alibabacloud-disk-group-snapshot
  2. add groupcontrollerserver for disk driver
  3. implement volumegroupsnapshot APIs
  4. allow users use volumegroupsnapshot by set feature-gate EnableVolumeGroupSnapshots=true

pls test with yaml like:

apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
kind: VolumeGroupSnapshot
metadata:
  name: new-group-snapshot-demo
spec:
  volumeGroupSnapshotClassName: alibabacloud-disk-group-snapshot
  source:
    selector:
      matchLabels:
        app: mysql

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

VolumeGroupSnapshot need K8s >= 1.27

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbeeSo
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
mowangdk
mowangdk reviewed Oct 15, 2024
View reviewed changes
pkg/disk/group_volume_snapshot_utils.go
return
}

if disk.MultiAttach != DiskMultiAttachDisabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECS limitation? add related docs here

pkg/disk/groupcontrollerserver.go
if !match {
klog.Errorf("CreateVolumeGroupSnapshot:: GroupSnapshot already exist with same name: name[%s], but with different SourceVolumeIDs[%v]", req.Name, sourceVolumeIds)
err := status.Errorf(codes.AlreadyExists, "groupSnapshot with the same name: %s but with different SourceVolumeIds already exist", req.GetName())
utils.CreateEvent(cs.recorder, ref, v1.EventTypeWarning, snapshotAlreadyExist, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the snapshot sidecar report events by default? If so , there's no need to report events in the CSI driver.

pkg/disk/group_volume_snapshot_utils.go
return &ecsParams, nil
}

func parseGroupSnapshotParameters(params map[string]string, ecsParams *createGroupSnapshotParams) (err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut test absent?

pkg/disk/group_volume_snapshot_utils.go
// if volumesnapshot have Annotations, use it first.
// storage.alibabacloud.com/snapshot-ttl
func parseGroupSnapshotAnnotations(anno map[string]string, ecsParams *createGroupSnapshotParams) error {
snapshotTTL := anno["storage.alibabacloud.com/snapshot-ttl"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make annotation key const

huww98
huww98 reviewed Oct 15, 2024
View reviewed changes
pkg/disk/group_volume_snapshot_utils.go
nCapacityInGiB = capacityInGiB

switch disk.Category {
case string(DiskESSD), string(DiskESSDAuto):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use switch, add a new field to CategoryDesc instead. So that we will not forget this when we add more disk type.

huww98
huww98 reviewed Oct 15, 2024
View reviewed changes
pkg/disk/group_volume_snapshot_utils.go
var capacityInGiB int
var err error
for _, sourceVolumeId := range sourceVolumeIds {
disks := getDisk(sourceVolumeId, GlobalConfigVar.EcsClient)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrieve all the disk in one DescribeDisks request? BTW, do we really need to do all these validations? Why not just let ECS do the validation and we just check the error code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowangdk mowangdk mowangdk left review comments

@huww98 huww98 huww98 left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbeeSo @k8s-ci-robot @mowangdk @huww98