Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check VBM node type automatically and support csi rund 3.0 protocol #1177

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Check VBM node type automatically and support csi rund 3.0 protocol #1177

wants to merge 1 commit into from

Conversation

mowangdk
Copy link
Contributor

@mowangdk mowangdk commented Oct 8, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2024
@mowangdk mowangdk changed the title Check VBM node type automatically, and support csi rund 3.0 protocol Check VBM node type automatically and support csi rund 3.0 protocol Oct 8, 2024
@mowangdk mowangdk force-pushed the bugfix/check_vbm_node_type_automatically branch from ba66ddb to 2beaa0a Compare October 8, 2024 08:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2024
@mowangdk mowangdk force-pushed the bugfix/check_vbm_node_type_automatically branch 5 times, most recently from dfc5aef to 9573d39 Compare October 9, 2024 09:01
@mowangdk mowangdk force-pushed the bugfix/check_vbm_node_type_automatically branch from 9573d39 to 7ba78d8 Compare October 14, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huww98 huww98 Awaiting requested review from huww98

@tydra-wang tydra-wang Awaiting requested review from tydra-wang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mowangdk @k8s-ci-robot