Skip to content

Commit

Permalink
Merge pull request #105 from leakingtapan/driver-name
Browse files Browse the repository at this point in the history
Update driver name and topology key
  • Loading branch information
Cheng Pan authored Nov 15, 2018
2 parents 6b589a7 + b11b08d commit ba91ac4
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions deploy/kubernetes/v1.12+/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ spec:
- name: ADDRESS
value: /csi/csi.sock
- name: DRIVER_REG_SOCK_PATH
value: /var/lib/kubelet/plugins/com.amazon.aws.csi.ebs/csi.sock
value: /var/lib/kubelet/plugins/ebs.csi.aws.com/csi.sock
- name: KUBE_NODE_NAME
valueFrom:
fieldRef:
Expand Down Expand Up @@ -128,7 +128,7 @@ spec:
type: Directory
- name: plugin-dir
hostPath:
path: /var/lib/kubelet/plugins/com.amazon.aws.csi.ebs/
path: /var/lib/kubelet/plugins/ebs.csi.aws.com/
type: DirectoryOrCreate
- name: registration-dir
hostPath:
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/v1.12+/provisioner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ spec:
allowPrivilegeEscalation: true
image: quay.io/k8scsi/csi-provisioner:v0.4.1
args:
- --provisioner=com.amazon.aws.csi.ebs
- --provisioner=ebs.csi.aws.com
- --csi-address=$(ADDRESS)
- --v=5
- --feature-gates=Topology=true
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/v1.12+/sample_app/storageclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ metadata:
name: slow
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: com.amazon.aws.csi.ebs
provisioner: ebs.csi.aws.com
2 changes: 1 addition & 1 deletion deploy/kubernetes/v1.[10,11]/node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ spec:
type: Directory
- name: plugin-dir
hostPath:
path: /var/lib/kubelet/plugins/com.amazon.aws.csi.ebs/
path: /var/lib/kubelet/plugins/ebs.csi.aws.com/
type: DirectoryOrCreate
- name: device-dir
hostPath:
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/v1.[10,11]/provisioner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ spec:
allowPrivilegeEscalation: true
image: quay.io/k8scsi/csi-provisioner:v0.4.1
args:
- --provisioner=com.amazon.aws.csi.ebs
- --provisioner=ebs.csi.aws.com
- --csi-address=$(ADDRESS)
- --v=5
env:
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/v1.[10,11]/sample_app/storageclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ metadata:
name: slow
annotations:
storageclass.kubernetes.io/is-default-class: "true"
provisioner: com.amazon.aws.csi.ebs
provisioner: ebs.csi.aws.com
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ There are several optional parameters that could be passed into `CreateVolumeReq
| "kmsKeyId" | | | The full ARN of the key to use when encrypting the volume. When not specified, the default KMS key is used |

### Topology
`com.amazon.aws.csi.ebs/zone` is the only topology key that represents the availability zone of which a volume is accessible.
`topology.ebs.csi.aws.com/zone` is the only topology key that represents the availability zone of which a volume is accessible.

To enable topology support on kuberetes, make sure `CSINodeInfo` and `CSIDriverRegistry` feature flags are enabled on both kubelet and kube-apiserver and `CSINodeInfo` CRD is installed on the cluster using:

Expand Down
4 changes: 2 additions & 2 deletions pkg/driver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import (
)

const (
driverName = "com.amazon.aws.csi.ebs"
topologyKey = driverName + "/zone"
driverName = "ebs.csi.aws.com"
topologyKey = "topology." + driverName + "/zone"
)

var (
Expand Down

0 comments on commit ba91ac4

Please sign in to comment.