If availableAttachments <= 0 clamp value to 1

Signed-off-by: Eddie Torres <[email protected]>
kubernetes-sigs · Dec 11, 2023 · c01d2fe · c01d2fe
1 parent 80fbe37
commit c01d2fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/driver/node.go b/pkg/driver/node.go
@@ -790,8 +790,8 @@ func (d *nodeService) getVolumesLimit() int64 {
 		availableAttachments = availableAttachments - enis - nvmeInstanceStoreVolumes
 	}
 	availableAttachments = availableAttachments - blockVolumes - 1 // -1 for root device
-	if availableAttachments < 0 {
-		availableAttachments = 0
+	if availableAttachments <= 0 {
+		availableAttachments = 1
 	}
 
 	maxEBSAttachments, ok := cloud.GetEBSLimitForInstanceType(instanceType)

diff --git a/pkg/driver/node_test.go b/pkg/driver/node_test.go
@@ -2158,7 +2158,7 @@ func TestNodeGetInfo(t *testing.T) {
 			volumeAttachLimit: -1,
 			attachedENIs:      1,
 			blockDevices:      27,
-			expMaxVolumes:     0,
+			expMaxVolumes:     1,
 			outpostArn:        emptyOutpostArn,
 		},
 		{
@@ -2170,7 +2170,7 @@ func TestNodeGetInfo(t *testing.T) {
 			volumeAttachLimit: -1,
 			attachedENIs:      1,
 			blockDevices:      39,
-			expMaxVolumes:     0,
+			expMaxVolumes:     1,
 			outpostArn:        emptyOutpostArn,
 		},
 		{
@@ -2182,7 +2182,7 @@ func TestNodeGetInfo(t *testing.T) {
 			volumeAttachLimit: -1,
 			attachedENIs:      27,
 			blockDevices:      1,
-			expMaxVolumes:     0,
+			expMaxVolumes:     1,
 			outpostArn:        emptyOutpostArn,
 		},
 		{