Skip to content

Commit

Permalink
Merge branch 'kubernetes-sigs:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
nirmalaagash authored Aug 25, 2021
2 parents ac4a32e + 8c6c7e0 commit da8dbf3
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 17 deletions.
4 changes: 4 additions & 0 deletions charts/aws-ebs-csi-driver/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Helm chart

## v2.1.0

* Custom `controller.updateStrategy` to set controller deployment strategy.

## v2.0.4

* Use chart app version as default image tag
Expand Down
8 changes: 3 additions & 5 deletions charts/aws-ebs-csi-driver/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: 1.2.0
name: aws-ebs-csi-driver
description: A Helm chart for AWS EBS CSI Driver
version: 2.0.4
version: 2.1.0
kubeVersion: ">=1.17.0-0"
home: https://github.com/kubernetes-sigs/aws-ebs-csi-driver
sources:
Expand All @@ -18,7 +18,5 @@ maintainers:
url: https://github.com/krmichel
annotations:
artifacthub.io/changes: |
- kind: changed
description: Use chart app version as default image tag
- kind: changed
description: Add updateStrategy to daemonsets
- kind: added
description: Custom controller.updateStrategy to set controller deployment strategy.
6 changes: 5 additions & 1 deletion charts/aws-ebs-csi-driver/templates/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ metadata:
{{- include "aws-ebs-csi-driver.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.controller.replicaCount }}
{{- with .Values.controller.updateStrategy }}
strategy:
{{ toYaml . | nindent 4 }}
{{- end }}
selector:
matchLabels:
app: ebs-csi-controller
Expand Down Expand Up @@ -55,7 +59,7 @@ spec:
{{- end }}
containers:
- name: ebs-plugin
image: {{ printf "%s:%s" .Values.image.repository (default (printf "v%s" .Chart.AppVersion) (toString .Values.image.tag)) }}
image: {{ printf "%s:%s" .Values.image.repository (default (printf "v%s" .Chart.AppVersion) (.Values.image.tag | toString)) }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
{{- if ne .Release.Name "kustomize" }}
Expand Down
5 changes: 5 additions & 0 deletions charts/aws-ebs-csi-driver/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ controller:
# region: us-east-1
region:
replicaCount: 2
updateStrategy: {}
# type: RollingUpdate
# rollingUpdate:
# maxSurge: 0
# maxUnavailable: 1
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
timeout: 3600s
steps:
- name: gcr.io/k8s-testimages/gcb-docker-gcloud:v20200421-a2bf5f8
- name: gcr.io/k8s-testimages/gcb-docker-gcloud:v20210722-085d930
entrypoint: ./hack/prow.sh
env:
- GIT_TAG=${_GIT_TAG}
Expand Down
26 changes: 16 additions & 10 deletions docs/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ You also might need to create a release branch, if it doesn't already exist. For

## Create the release commit in the release branch

### Generate the CHANGELOG
### Update `CHANGELOG-0.x.md`
We need to generate the CHANGELOG for the new release by running `./hack/release`. You need to pass previous release tag to generate the changelog.

```
Expand All @@ -45,14 +45,11 @@ python3 release --github-user=ayberk --github-token=$GITHUB_TOKEN note --since <

This will print the CHANGELOG to stdout. You should create a new section for the new version and copy the output there.

### Update the README
### Update `docs/README.md`
Search for any references to the previous version on the README, and update them if necessary.

### Update the build and helm deployment files
1. Update the VERSION variable in the Makefile
1. Update Helm values
- `aws-ebs-csi-driver/values.yaml`
- `aws-ebs-csi-driver/Chart.yaml`
### Update `Makefile`
Update the VERSION variable in the Makefile

### Send a release PR to the release branch
At this point you should have all changes required for the release commit. Verify the changes via `git diff` and send a new PR with the release commit against the release branch. Note that if it doesn't exist, you'll need someone with write privileges to create it for you.
Expand Down Expand Up @@ -86,15 +83,21 @@ In ECR:
- `aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin 602401143452.dkr.ecr.us-west-2.amazonaws.com`
- `docker pull 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/aws-ebs-csi-driver:v1.1.1`

## Create a post-release commit in the release branch
## Create the post-release commit in the release branch

### Update the kustomize deployment files
### Update `charts/aws-ebs-csi-driver`
1. Update Helm `appVersion`, `version`, `tag`, and CHANGELOG
- `charts/aws-ebs-csi-driver/Chart.yaml`
- `charts/aws-ebs-csi-driver/values.yaml`
- `charts/aws-ebs-csi-driver/CHANGELOG.md`

### Update `deploy/kubernetes`
1. Update the kustomize overlays
- `deploy/kubernetes/overlays/stable/kustomization.yaml`
- `deploy/kubernetes/overlays/stable/ecr/kustomization.yaml`

### Send a post-release PR to the release branch
The kustomize deployment files must not be updated to refer to the new images until after the images have been verified available, therefore it's necessary to make these changes in a post-release PR rather than the original release PR.
The helm and kustomize deployment files must not be updated to refer to the new images until after the images have been verified available, therefore it's necessary to make these changes in a post-release PR rather than the original release PR.

## Merge the release and post-release commits to the main branch

Expand All @@ -104,3 +107,6 @@ Send a PR to merge both the release and post-release commits to the main branch.

Visit the [Releases](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/releases) pages to verify we have a new helm chart release.

## Update AWS EKS documentation

Update the AWS EKS documentation https://docs.aws.amazon.com/eks/latest/userguide/ebs-csi.html by submitting a PR https://github.com/awsdocs/amazon-eks-user-guide/blob/master/doc_source/ebs-csi.md. For example, if the release raises the Kubernetes version requirement then the doc must reflect that.

0 comments on commit da8dbf3

Please sign in to comment.