Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename VolumeNameTagKey #161

Closed
leakingtapan opened this issue Dec 26, 2018 · 1 comment · Fixed by #174
Closed

Rename VolumeNameTagKey #161

leakingtapan opened this issue Dec 26, 2018 · 1 comment · Fixed by #174
Assignees
@leakingtapan
Milestone
beta

Comments

@leakingtapan
Copy link
Contributor

Is your feature request related to a problem?/Why is this needed
VolumeNameTagKey is used as tag when creating EBS volume. It is used to implement idempotency when creating a new volume the key is used to check if the volume is already created.

The current key is com.amazon.aws.csi.volume. This is the old driver name which is unnecessarily named this way. We could rename the key to be CSIVolumeName to align it to our design

/cc @jsafrane
@leakingtapan leakingtapan added this to the beta milestone Dec 26, 2018
@leakingtapan
Copy link
Contributor Author

/assign

leakingtapan pushed a commit to leakingtapan/ebs-csi-driver that referenced this issue Jan 8, 2019
Rename VolumeNameTagKey
76de40d 
Fixes: kubernetes-sigs#161
@leakingtapan leakingtapan mentioned this issue Jan 8, 2019
Merged
huffmanca pushed a commit to huffmanca/aws-ebs-csi-driver that referenced this issue Sep 3, 2020
@openshift-merge-robot
Merge pull request kubernetes-sigs#161 from openshift-bot/updating-do…
abc0ba4 
…ckerfile.openshift.rhel7-baseimages-to-mach-ocp-build-data-config

Bug 1872080: Updating Dockerfile.openshift.rhel7 baseimages to mach ocp-build-data config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leakingtapan leakingtapan

Labels
None yet
Projects
None yet
Milestone
beta
Development

Successfully merging a pull request may close this issue.

Rename VolumeNameTagKey leakingtapan/ebs-csi-driver
1 participant
@leakingtapan