Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation Announcement] v2.28.0 of the EBS CSI Driver Helm Chart is the last minor version to support --reuse-values #1864

Closed
ConnorJC3 opened this issue Dec 13, 2023 · 3 comments

Comments

@ConnorJC3
Copy link
Contributor

ConnorJC3 commented Dec 13, 2023

Summary

Today, the EBS CSI Driver supports upgrading with --reuse-values in some scenarios (opt-in features do not support it). In a future release, that support will no longer be tested for or guaranteed.

If you use --reuse-values today, we strongly suggest you consider switching to --reset-then-reuse-values, a new Helm flag available in Helm 3.14.0 and later.

FAQ

I don't upgrade with --reuse-values, does this affect me?

If you (or a tool on your behalf) does not explicitly pass --reuse-values to Helm, this change does not affect you. helm upgrade, helm upgrade --reset-values, and helm upgrade --reset-then-reuse-values will still be supported.

Why is this happening?

--reuse-values behaves in an unintuitive way that greatly increases the burden on maintainers and contributors to the EBS CSI Driver Helm chart (this blog post provides a useful summary of the issue with --reuse-values). The team evaluated this burden and decided to deprecate --reuse-values upgrade support, which is consistent with other popular Helm charts.

When will this happen?

The specific release this deprecation will take place in is undecided at the moment. When more information is available, it will be announced on this issue and in the EBS CSI Helm chart CHANGELOG.

Update: As announced in the CHANGELOG, v2.28.0 will be the last minor version of the EBS CSI Driver Helm Chart to support --reuse values.

I have more questions or feedback

Please comment on this issue to ask additional questions about or provide feedback on this change.

@torredil torredil pinned this issue Dec 13, 2023
@sossickd
Copy link

Whatever

bodgit added a commit to bodgit/aws-ebs-csi-driver that referenced this issue Jan 22, 2024
@AndrewSirenko AndrewSirenko unpinned this issue Feb 8, 2024
@ConnorJC3 ConnorJC3 pinned this issue Feb 8, 2024
@ConnorJC3 ConnorJC3 changed the title [Deprecation Announcement] The EBS CSI Driver Helm chart will stop supporting --reuse-values [Deprecation Announcement] v2.28.0 of the EBS CSI Driver Helm Chart is the last minor version to support --reuse-values Feb 20, 2024
@ConnorJC3
Copy link
Contributor Author

/close

This deprecation has occurred as of v2.29.0 - the EBS CSI Driver chart no longer supports upgrading with --reuse-values, closing this announcement out.

We will continue to monitor this issue if anyone has any questions about the change.

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: Closing this issue.

In response to this:

/close

This deprecation has occurred as of v2.29.0 - the EBS CSI Driver chart no longer supports upgrading with --reuse-values, closing this announcement out.

We will continue to monitor this issue if anyone has any questions about the change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@torredil torredil unpinned this issue Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants